Skip to content

Commit 1282043

Browse files
100pah100pah
committed
release 3.8.4
1 parent cc334de commit 1282043

16 files changed

+103
-67
lines changed

‎dist/echarts-en.common.js

Lines changed: 21 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10456,7 +10456,7 @@ var instances$1 = {}; // ZRender实例map索引
1045610456
/**
1045710457
* @type {string}
1045810458
*/
10459-
var version$1 = '3.7.2';
10459+
var version$1 = '3.7.3';
1046010460

1046110461
/**
1046210462
* Initializing a zrender instance
@@ -20880,10 +20880,10 @@ var loadingDefault = function (api, opts) {
2088020880
var each = each$1;
2088120881
var parseClassType = ComponentModel.parseClassType;
2088220882

20883-
var version = '3.8.3';
20883+
var version = '3.8.4';
2088420884

2088520885
var dependencies = {
20886-
zrender: '3.7.2'
20886+
zrender: '3.7.3'
2088720887
};
2088820888

2088920889
var PRIORITY_PROCESSOR_FILTER = 1000;
@@ -47452,10 +47452,13 @@ var svgTextDrawRectText = function (el, rect, textRect) {
4745247452

4745347453
var text = style.text;
4745447454
// Convert to string
47455-
text != null && (text += '');
47456-
if (!text) {
47455+
if (text == null) {
47456+
// Draw no text only when text is set to null, but not ''
4745747457
return;
4745847458
}
47459+
else {
47460+
text += '';
47461+
}
4745947462

4746047463
var textSvgEl = el.__textSvgEl;
4746147464
if (! textSvgEl) {
@@ -48275,10 +48278,12 @@ inherits(ClippathManager, Definable);
4827548278
* Update clipPath.
4827648279
*
4827748280
* @param {Displayable} displayable displayable element
48278-
* @param {SVGElement} svgElement SVG element of displayable
4827948281
*/
48280-
ClippathManager.prototype.update = function (displayable, svgElement) {
48281-
this.updateDom(svgElement, displayable.__clipPaths, false);
48282+
ClippathManager.prototype.update = function (displayable) {
48283+
var svgEl = this.getSvgElement(displayable);
48284+
if (svgEl) {
48285+
this.updateDom(svgEl, displayable.__clipPaths, false);
48286+
}
4828248287

4828348288
var textEl = this.getTextSvgElement(displayable);
4828448289
if (textEl) {
@@ -48370,7 +48375,13 @@ ClippathManager.prototype.updateDom = function (
4837048375
}
4837148376

4837248377
var pathEl = this.getSvgElement(clipPath);
48373-
clipPathEl.appendChild(pathEl);
48378+
/**
48379+
* Use `cloneNode()` here to appendChild to multiple parents,
48380+
* which may happend when Text and other shapes are using the same
48381+
* clipPath. Since Text will create an extra clipPath DOM due to
48382+
* different transform rules.
48383+
*/
48384+
clipPathEl.appendChild(pathEl.cloneNode());
4837448385

4837548386
parentEl.setAttribute('clip-path', 'url(#' + id + ')');
4837648387

@@ -48541,11 +48552,9 @@ SVGPainter.prototype = {
4854148552
if (!displayable.invisible) {
4854248553
if (displayable.__dirty) {
4854348554
svgProxy && svgProxy.brush(displayable);
48544-
var el = getSvgElement(displayable)
48545-
|| getTextSvgElement(displayable);
4854648555

4854748556
// Update clipPath
48548-
this.clipPathManager.update(displayable, el);
48557+
this.clipPathManager.update(displayable);
4854948558

4855048559
// Update gradient
4855148560
if (displayable.style) {

‎dist/echarts-en.common.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/echarts-en.js

Lines changed: 21 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10456,7 +10456,7 @@ var instances$1 = {}; // ZRender实例map索引
1045610456
/**
1045710457
* @type {string}
1045810458
*/
10459-
var version$1 = '3.7.2';
10459+
var version$1 = '3.7.3';
1046010460

1046110461
/**
1046210462
* Initializing a zrender instance
@@ -20946,10 +20946,10 @@ var loadingDefault = function (api, opts) {
2094620946
var each = each$1;
2094720947
var parseClassType = ComponentModel.parseClassType;
2094820948

20949-
var version = '3.8.3';
20949+
var version = '3.8.4';
2095020950

2095120951
var dependencies = {
20952-
zrender: '3.7.2'
20952+
zrender: '3.7.3'
2095320953
};
2095420954

2095520955
var PRIORITY_PROCESSOR_FILTER = 1000;
@@ -73410,10 +73410,13 @@ var svgTextDrawRectText = function (el, rect, textRect) {
7341073410

7341173411
var text = style.text;
7341273412
// Convert to string
73413-
text != null && (text += '');
73414-
if (!text) {
73413+
if (text == null) {
73414+
// Draw no text only when text is set to null, but not ''
7341573415
return;
7341673416
}
73417+
else {
73418+
text += '';
73419+
}
7341773420

7341873421
var textSvgEl = el.__textSvgEl;
7341973422
if (! textSvgEl) {
@@ -74233,10 +74236,12 @@ inherits(ClippathManager, Definable);
7423374236
* Update clipPath.
7423474237
*
7423574238
* @param {Displayable} displayable displayable element
74236-
* @param {SVGElement} svgElement SVG element of displayable
7423774239
*/
74238-
ClippathManager.prototype.update = function (displayable, svgElement) {
74239-
this.updateDom(svgElement, displayable.__clipPaths, false);
74240+
ClippathManager.prototype.update = function (displayable) {
74241+
var svgEl = this.getSvgElement(displayable);
74242+
if (svgEl) {
74243+
this.updateDom(svgEl, displayable.__clipPaths, false);
74244+
}
7424074245

7424174246
var textEl = this.getTextSvgElement(displayable);
7424274247
if (textEl) {
@@ -74328,7 +74333,13 @@ ClippathManager.prototype.updateDom = function (
7432874333
}
7432974334

7433074335
var pathEl = this.getSvgElement(clipPath);
74331-
clipPathEl.appendChild(pathEl);
74336+
/**
74337+
* Use `cloneNode()` here to appendChild to multiple parents,
74338+
* which may happend when Text and other shapes are using the same
74339+
* clipPath. Since Text will create an extra clipPath DOM due to
74340+
* different transform rules.
74341+
*/
74342+
clipPathEl.appendChild(pathEl.cloneNode());
7433274343

7433374344
parentEl.setAttribute('clip-path', 'url(#' + id + ')');
7433474345

@@ -74499,11 +74510,9 @@ SVGPainter.prototype = {
7449974510
if (!displayable.invisible) {
7450074511
if (displayable.__dirty) {
7450174512
svgProxy && svgProxy.brush(displayable);
74502-
var el = getSvgElement(displayable)
74503-
|| getTextSvgElement(displayable);
7450474513

7450574514
// Update clipPath
74506-
this.clipPathManager.update(displayable, el);
74515+
this.clipPathManager.update(displayable);
7450774516

7450874517
// Update gradient
7450974518
if (displayable.style) {

‎dist/echarts-en.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/echarts-en.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/echarts-en.simple.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10160,7 +10160,7 @@ var painterCtors = {
1016010160
/**
1016110161
* @type {string}
1016210162
*/
10163-
var version$1 = '3.7.2';
10163+
var version$1 = '3.7.3';
1016410164

1016510165
/**
1016610166
* Initializing a zrender instance
@@ -20320,10 +20320,10 @@ var loadingDefault = function (api, opts) {
2032020320
var each = each$1;
2032120321
var parseClassType = ComponentModel.parseClassType;
2032220322

20323-
var version = '3.8.3';
20323+
var version = '3.8.4';
2032420324

2032520325
var dependencies = {
20326-
zrender: '3.7.2'
20326+
zrender: '3.7.3'
2032720327
};
2032820328

2032920329
var PRIORITY_PROCESSOR_FILTER = 1000;

‎dist/echarts-en.simple.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/echarts.common.js

Lines changed: 21 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10456,7 +10456,7 @@ var instances$1 = {}; // ZRender实例map索引
1045610456
/**
1045710457
* @type {string}
1045810458
*/
10459-
var version$1 = '3.7.2';
10459+
var version$1 = '3.7.3';
1046010460

1046110461
/**
1046210462
* Initializing a zrender instance
@@ -20880,10 +20880,10 @@ var loadingDefault = function (api, opts) {
2088020880
var each = each$1;
2088120881
var parseClassType = ComponentModel.parseClassType;
2088220882

20883-
var version = '3.8.3';
20883+
var version = '3.8.4';
2088420884

2088520885
var dependencies = {
20886-
zrender: '3.7.2'
20886+
zrender: '3.7.3'
2088720887
};
2088820888

2088920889
var PRIORITY_PROCESSOR_FILTER = 1000;
@@ -47452,10 +47452,13 @@ var svgTextDrawRectText = function (el, rect, textRect) {
4745247452

4745347453
var text = style.text;
4745447454
// Convert to string
47455-
text != null && (text += '');
47456-
if (!text) {
47455+
if (text == null) {
47456+
// Draw no text only when text is set to null, but not ''
4745747457
return;
4745847458
}
47459+
else {
47460+
text += '';
47461+
}
4745947462

4746047463
var textSvgEl = el.__textSvgEl;
4746147464
if (! textSvgEl) {
@@ -48275,10 +48278,12 @@ inherits(ClippathManager, Definable);
4827548278
* Update clipPath.
4827648279
*
4827748280
* @param {Displayable} displayable displayable element
48278-
* @param {SVGElement} svgElement SVG element of displayable
4827948281
*/
48280-
ClippathManager.prototype.update = function (displayable, svgElement) {
48281-
this.updateDom(svgElement, displayable.__clipPaths, false);
48282+
ClippathManager.prototype.update = function (displayable) {
48283+
var svgEl = this.getSvgElement(displayable);
48284+
if (svgEl) {
48285+
this.updateDom(svgEl, displayable.__clipPaths, false);
48286+
}
4828248287

4828348288
var textEl = this.getTextSvgElement(displayable);
4828448289
if (textEl) {
@@ -48370,7 +48375,13 @@ ClippathManager.prototype.updateDom = function (
4837048375
}
4837148376

4837248377
var pathEl = this.getSvgElement(clipPath);
48373-
clipPathEl.appendChild(pathEl);
48378+
/**
48379+
* Use `cloneNode()` here to appendChild to multiple parents,
48380+
* which may happend when Text and other shapes are using the same
48381+
* clipPath. Since Text will create an extra clipPath DOM due to
48382+
* different transform rules.
48383+
*/
48384+
clipPathEl.appendChild(pathEl.cloneNode());
4837448385

4837548386
parentEl.setAttribute('clip-path', 'url(#' + id + ')');
4837648387

@@ -48541,11 +48552,9 @@ SVGPainter.prototype = {
4854148552
if (!displayable.invisible) {
4854248553
if (displayable.__dirty) {
4854348554
svgProxy && svgProxy.brush(displayable);
48544-
var el = getSvgElement(displayable)
48545-
|| getTextSvgElement(displayable);
4854648555

4854748556
// Update clipPath
48548-
this.clipPathManager.update(displayable, el);
48557+
this.clipPathManager.update(displayable);
4854948558

4855048559
// Update gradient
4855148560
if (displayable.style) {

‎dist/echarts.common.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/echarts.js

Lines changed: 21 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10456,7 +10456,7 @@ var instances$1 = {}; // ZRender实例map索引
1045610456
/**
1045710457
* @type {string}
1045810458
*/
10459-
var version$1 = '3.7.2';
10459+
var version$1 = '3.7.3';
1046010460

1046110461
/**
1046210462
* Initializing a zrender instance
@@ -20946,10 +20946,10 @@ var loadingDefault = function (api, opts) {
2094620946
var each = each$1;
2094720947
var parseClassType = ComponentModel.parseClassType;
2094820948

20949-
var version = '3.8.3';
20949+
var version = '3.8.4';
2095020950

2095120951
var dependencies = {
20952-
zrender: '3.7.2'
20952+
zrender: '3.7.3'
2095320953
};
2095420954

2095520955
var PRIORITY_PROCESSOR_FILTER = 1000;
@@ -73410,10 +73410,13 @@ var svgTextDrawRectText = function (el, rect, textRect) {
7341073410

7341173411
var text = style.text;
7341273412
// Convert to string
73413-
text != null && (text += '');
73414-
if (!text) {
73413+
if (text == null) {
73414+
// Draw no text only when text is set to null, but not ''
7341573415
return;
7341673416
}
73417+
else {
73418+
text += '';
73419+
}
7341773420

7341873421
var textSvgEl = el.__textSvgEl;
7341973422
if (! textSvgEl) {
@@ -74233,10 +74236,12 @@ inherits(ClippathManager, Definable);
7423374236
* Update clipPath.
7423474237
*
7423574238
* @param {Displayable} displayable displayable element
74236-
* @param {SVGElement} svgElement SVG element of displayable
7423774239
*/
74238-
ClippathManager.prototype.update = function (displayable, svgElement) {
74239-
this.updateDom(svgElement, displayable.__clipPaths, false);
74240+
ClippathManager.prototype.update = function (displayable) {
74241+
var svgEl = this.getSvgElement(displayable);
74242+
if (svgEl) {
74243+
this.updateDom(svgEl, displayable.__clipPaths, false);
74244+
}
7424074245

7424174246
var textEl = this.getTextSvgElement(displayable);
7424274247
if (textEl) {
@@ -74328,7 +74333,13 @@ ClippathManager.prototype.updateDom = function (
7432874333
}
7432974334

7433074335
var pathEl = this.getSvgElement(clipPath);
74331-
clipPathEl.appendChild(pathEl);
74336+
/**
74337+
* Use `cloneNode()` here to appendChild to multiple parents,
74338+
* which may happend when Text and other shapes are using the same
74339+
* clipPath. Since Text will create an extra clipPath DOM due to
74340+
* different transform rules.
74341+
*/
74342+
clipPathEl.appendChild(pathEl.cloneNode());
7433274343

7433374344
parentEl.setAttribute('clip-path', 'url(#' + id + ')');
7433474345

@@ -74499,11 +74510,9 @@ SVGPainter.prototype = {
7449974510
if (!displayable.invisible) {
7450074511
if (displayable.__dirty) {
7450174512
svgProxy && svgProxy.brush(displayable);
74502-
var el = getSvgElement(displayable)
74503-
|| getTextSvgElement(displayable);
7450474513

7450574514
// Update clipPath
74506-
this.clipPathManager.update(displayable, el);
74515+
this.clipPathManager.update(displayable);
7450774516

7450874517
// Update gradient
7450974518
if (displayable.style) {

0 commit comments

Comments
 (0)