Skip to content

onRequestPermissionResult deprecation issue #1388

New issue
New issue
Open
#1405
Open
onRequestPermissionResult deprecation issue#1388
#1405
@jacobg

Description

@jacobg
jacobg
opened on Jan 5, 2022

onRequestPermissionResult is marked as deprecated in favor of onRequestPermissionsResult:

cordova-android/framework/src/org/apache/cordova/CordovaPlugin.java

Lines 418 to 424 in a1ed1c0

* @deprecated Use {@link #onRequestPermissionsResult} instead.
*/
@Deprecated
public void onRequestPermissionResult(int requestCode, String[] permissions,
int[] grantResults) throws JSONException {
}

However, CordovaInterfaceImpl calls the deprecated method instead of the new one:

cordova-android/framework/src/org/apache/cordova/CordovaInterfaceImpl.java

Lines 218 to 224 in a1ed1c0

public void onRequestPermissionResult(int requestCode, String[] permissions,
int[] grantResults) throws JSONException {
Pair<CordovaPlugin, Integer> callback = permissionResultCallbacks.getAndRemoveCallback(requestCode);
if(callback != null) {
callback.first.onRequestPermissionResult(callback.second, permissions, grantResults);
}
}

Maybe should CordovaPlugin's default implementation of onRequestPermissionResult call the new onRequestPermissionsResult method until onRequestPermissionResult is removed?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions