Skip to content

Commit cbc31be

Browse files
authored
Reuse secret instead of creating every time (#36955)
* Reuse secret instead of creating every time * Reuse secret instead of creating every time * lint * lint
1 parent 1cf077f commit cbc31be

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

sdks/python/apache_beam/transforms/util_test.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
import math
2929
import random
3030
import re
31-
import sys
3231
import time
3332
import unittest
3433
import warnings
@@ -320,9 +319,7 @@ class GroupByEncryptedKeyTest(unittest.TestCase):
320319
def setUpClass(cls):
321320
if secretmanager is not None:
322321
cls.project_id = 'apache-beam-testing'
323-
py_version = f'_py{sys.version_info.major}{sys.version_info.minor}'
324-
secret_postfix = datetime.now().strftime('%m%d_%H%M%S') + py_version
325-
cls.secret_id = 'gbek_util_secret_tests_' + secret_postfix
322+
cls.secret_id = 'gbek_util_secret_tests'
326323
cls.client = secretmanager.SecretManagerServiceClient()
327324
cls.project_path = f'projects/{cls.project_id}'
328325
cls.secret_path = f'{cls.project_path}/secrets/{cls.secret_id}'
@@ -350,11 +347,6 @@ def setUpClass(cls):
350347
cls.gcp_secret = GcpSecret(version_name)
351348
cls.secret_option = f'type:GcpSecret;version_name:{version_name}'
352349

353-
@classmethod
354-
def tearDownClass(cls):
355-
if secretmanager is not None:
356-
cls.client.delete_secret(request={'name': cls.secret_path})
357-
358350
def test_gbek_fake_secret_manager_roundtrips(self):
359351
fakeSecret = FakeSecret()
360352

0 commit comments

Comments
 (0)