chore: Suppress 'as' test is always true warning

Author: kou

.github/workflows/test.yaml

@@ -86,8 +86,6 @@ jobs:
         run: |
           docker compose build ubuntu
       - name: Run
-        # We remove this when we support Swift 6.0 or later.
-        continue-on-error: ${{ matrix.swift-version != '5.10' }}
         run: |
           docker compose run --rm ubuntu
       - name: Fix permission for .docker/

Arrow/Sources/Arrow/ArrowReader.swift

@@ -258,10 +258,8 @@ public class ArrowReader { // swiftlint:disable:this type_body_length
                     result.batches.append(recordBatch)
                     offset += Int(message.bodyLength + Int64(length))
                     length = getUInt32(input, offset: offset)
-                } catch let error as ArrowError {
-                    return .failure(error)
                 } catch {
-                    return .failure(.unknownError("Unexpected error: \(error)"))
+                    return .failure(error)
                 }
             case .schema:
                 schemaMessage = message.header(type: org_apache_arrow_flatbuf_Schema.self)!
@@ -343,10 +341,8 @@ public class ArrowReader { // swiftlint:disable:this type_body_length
                         data: fileData,
                         messageEndOffset: messageEndOffset).get()
                     result.batches.append(recordBatch)
-                } catch let error as ArrowError {
-                    return .failure(error)
                 } catch {
-                    return .failure(.unknownError("Unexpected error: \(error)"))
+                    return .failure(error)
                 }
             default:
                 return .failure(.unknownError("Unhandled header type: \(message.headerType)"))
@@ -405,10 +401,8 @@ public class ArrowReader { // swiftlint:disable:this type_body_length
                     data: dataBody, messageEndOffset: 0).get()
                 result.batches.append(recordBatch)
                 return .success(())
-            } catch let error as ArrowError {
-                return .failure(error)
             } catch {
-                return .failure(.unknownError("Unexpected error: \(error)"))
+                return .failure(error)
             }
         default:
             return .failure(.unknownError("Unhandled header type: \(message.headerType)"))