Pass linter severity lists explicitly

Internal-tag: [#81121]
Signed-off-by: Maciej Kurc <[email protected]>

Author: mkurc-ant

vc_static/defs.bzl

@@ -29,28 +29,12 @@ def _value_to_tcl(value):
 def _dict_to_tcl(dictionary):
     tcl = []
     for name, value in dictionary.items():
-        if name == "custom_severities":
-            failing_severities_def = ["set", "failing_severities", "[split"]
-            all_severities_def = ["set", "all_severities", "[split"]
-            close_tcl_list = "\".\"]"
-            failing_severities = []
-            all_severities = []
-            for k, v in value.items():
-                severities = [".".join(v)]
-                if k != "info":
-                    failing_severities.extend(severities)
-                all_severities.extend(severities)
-            failing_severities_def.extend([".".join(failing_severities), close_tcl_list])
-            all_severities_def.extend([".".join(all_severities), close_tcl_list])
-            tcl.append(" ".join(all_severities_def))
-            tcl.append(" ".join(failing_severities_def))
+        definition = ["set", name]
+        if type(value) == "list":
+            definition.extend([_value_to_tcl(" ".join(value))])
         else:
-            definition = ["set", name]
-            if type(value) == "list":
-                definition.extend([_value_to_tcl(" ".join(value))])
-            else:
-                definition.append(_value_to_tcl(value))
-            tcl.append(" ".join(definition))
+            definition.append(_value_to_tcl(value))
+        tcl.append(" ".join(definition))
 
     return "\n".join(tcl)
 
@@ -70,7 +54,8 @@ def _vc_static_lint(ctx):
 
     tcl_variables = {
         "config_files": [f.path for f in ctx.files.config_files],
-        "custom_severities": ctx.attr.custom_severities,
+        "all_severities": ctx.attr.severities,
+        "failing_severities": ctx.attr.failing_severities,
         "enable_liberty": ctx.attr.enable_liberty,
         "goal_name": ctx.attr.goal_name,
         "include_dirs": depset([f.dirname for f in (all_srcs + all_hdrs)]).to_list(),
@@ -129,16 +114,6 @@ vc_static_lint = rule(
             doc = "Config files",
             allow_files = True,
         ),
-        "custom_severities": attr.string_list_dict(
-            doc = "Dictionary of severities (keys) and the overriding names (values)",
-            # buildifier: disable=unsorted-dict-items
-            default = {
-                "fatal": ["fatal"],
-                "error": ["error"],
-                "warning": ["warning"],
-                "info": ["info"],
-            },
-        ),
         "enable_liberty": attr.bool(
             doc = "Enable liberty database load",
             default = False,
@@ -147,6 +122,14 @@ vc_static_lint = rule(
             doc = "Lint goal name",
             default = "lint_rtl",
         ),
+        "severities": attr.string_list(
+            doc = "List of lint severity names to report",
+            default = ["fatal", "error", "warning", "info"],
+        ),
+        "failing_severities": attr.string_list(
+            doc = "List of lint severity names to fail on",
+            default = ["fatal", "error", "warning"],
+        ),
         "module": attr.label(
             doc = "The top level module target to lint.",
             providers = [VerilogInfo],