Skip to content

fix(input): copy input state classes to md-input-container #2191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jelbourn merged 1 commit into from
Dec 14, 2016
Merged

fix(input): copy input state classes to md-input-container #2191

jelbourn merged 1 commit into from
Dec 14, 2016

Conversation

@mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Dec 13, 2016

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 13, 2016
@mmalerba
Copy link
Contributor Author

mmalerba commented Dec 13, 2016

@jelbourn directly binding to the ngControl of the content child doesn't seem to cause any issues. @kara asked for some sanity checks on formControl as well so I added that to the demo.

jelbourn
jelbourn approved these changes Dec 14, 2016
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 14, 2016
@jelbourn jelbourn merged commit f0c4148 into angular:master Dec 14, 2016
@mmalerba mmalerba deleted the input2 branch December 25, 2016 23:37
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 6, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mmalerba @jelbourn @googlebot