Skip to content

Commit d98c4b6

Browse files
committed
log view
1 parent 9ec4ee4 commit d98c4b6

File tree

12 files changed

+298
-334
lines changed

12 files changed

+298
-334
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ With Git support enabled, DAGs are stored in a Git repository, enabling users to
1515
### System Requirements
1616

1717
* Airflow Versions
18-
* 2.0.0 or newer
18+
* 2.x or 3.x
1919
* git Versions (git is not required if git support is disabled)
2020
* 2.0 or newer
2121

@@ -76,7 +76,7 @@ You can find the following images there:
7676

7777
3. Restart the Airflow Web Server
7878

79-
4. Open Admin - DAGs Code Editor
79+
4. Open 'Plugins' (for Airflow 3.x) or 'Admin' (for Airflow 2.x) - 'Airflow Code Editor'
8080

8181

8282
### Config Options

airflow_code_editor/commons.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
PLUGIN_NAME = 'code_editor'
5656
PLUGIN_LONG_NAME = 'Airflow Code Editor'
5757
MENU_CATEGORY = 'Admin'
58-
MENU_LABEL = 'DAGs Code Editor'
58+
MENU_LABEL = 'Airflow Code Editor'
5959
API_REFERENCE_MENU_CATEGORY = 'Docs'
6060
API_REFERENCE_LABEL = 'Airflow Code Editor REST API Reference'
6161
ROUTE = '/' + PLUGIN_NAME

airflow_code_editor/fastapi_app.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
from fastapi.templating import Jinja2Templates
2525

2626
from airflow_code_editor.api.fastapi_endpoints import app
27-
from airflow_code_editor.commons import PLUGIN_LONG_NAME, PLUGIN_NAME
27+
from airflow_code_editor.commons import PLUGIN_LONG_NAME, PLUGIN_NAME, MENU_LABEL
2828
from airflow_code_editor.utils import is_enabled
2929

3030
__all__ = ["fastapi_app"]
@@ -53,7 +53,7 @@ def index(request: Request):
5353
}
5454

5555
menu = {
56-
"name": PLUGIN_LONG_NAME,
56+
"name": MENU_LABEL,
5757
"href": f"{PLUGIN_NAME}/",
5858
}
5959

airflow_code_editor/static/airflow_code_editor.js

Lines changed: 62 additions & 62 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

airflow_code_editor/static/airflow_code_editor.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

airflow_code_editor/static/css/style.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

airflow_code_editor/static/icon.png

1.96 KB
Loading

airflow_code_editor/static/jquery-3.7.1.min.js

Lines changed: 0 additions & 2 deletions
This file was deleted.

airflow_code_editor/templates/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
<base href="/code_editor/" />
66
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
77
<title>Airflow Code Editor</title>
8+
<link rel="icon" type="image/png" href="static/icon.png" />
89
<script type="module" src="static/airflow_code_editor.js"></script>
9-
<script src="static/jquery-3.7.1.min.js"></script>
1010
<link rel="stylesheet" type="text/css" href="static/css/bootstrap.min.css" />
1111
<link rel="stylesheet" type="text/css" href="static/css/fontawesome.min.css" />
1212
<link rel="stylesheet" type="text/css" href="static/css/regular.min.css" />

src/components/HistoryView.vue

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<splitpanes class="default-theme">
33
<pane key="1" :size="50" class="history-view">
44
<spinner v-show="loading"/>
5-
<log ref="log" @updateCommit="updateCommit" />
5+
<log :uuid="uuid" :target="target" ref="log" @updateCommit="updateCommit" />
66
</pane>
77
<pane key="2" :size="50" class="commit-view">
88
<ul class="tabs">
@@ -79,7 +79,7 @@ export default defineComponent({
7979
'commit': ShowCommit,
8080
'spinner': Spinner,
8181
},
82-
props: [ 'config', 'target' ],
82+
props: [ 'config', 'target', 'uuid' ],
8383
data() {
8484
return {
8585
tab: 'commit', // active tab
@@ -105,7 +105,6 @@ export default defineComponent({
105105
if ((this.id != target.id) || (this.name != target.name)) {
106106
this.id = target.id;
107107
this.name = target.name;
108-
this.$refs.log.update(this.name);
109108
this.updateCommit({ commit: this.name });
110109
this.updateLocation();
111110
}

0 commit comments

Comments
 (0)