fix: parse comma or newline-separated cmp names

Author: amtrack

package.json

@@ -16,6 +16,7 @@
     "@oclif/errors": "1.3.4",
     "@salesforce/command": "3.0.5",
     "@salesforce/core": "2.15.2",
+    "get-stdin": "8.0.0",
     "lodash": "4.17.20",
     "picomatch": "2.2.2",
     "tslib": "2.0.3"

src/cli.ts

@@ -8,7 +8,7 @@ export async function getMetadataComponentsFromStdinOrString(
 ): Promise<Array<MetadataComponent>> {
   let rawComponentNames = [];
   if (commaSeparatedMetadataComponentNames === '-') {
-    rawComponentNames = await getStdin().split('\n');
+    rawComponentNames = (await getStdin()).split('\n');
   } else {
     rawComponentNames = commaSeparatedMetadataComponentNames.split(',');
   }

src/commands/package.xml/create.ts

@@ -28,7 +28,8 @@ export default class PackageXmlCreateCommand extends SfdxCommand {
   protected static flagsConfig = {
     metadata: flags.string({
       char: 'm',
-      description: 'comma-separated list of metadata component names'
+      description: 'comma-separated list of metadata component names',
+      required: true
     }),
     resultfile: flags.filepath({
       char: 'f',

test/cli.test.ts

@@ -0,0 +1,29 @@
+import { expect } from 'chai';
+import { getMetadataComponentsFromStdinOrString } from '../src/cli';
+
+describe('cli', () => {
+  describe('getMetadataComponentsFromStdinOrString()', () => {
+    it('parses comma-separated metadata component names from a string', async () => {
+      expect(
+        await getMetadataComponentsFromStdinOrString(
+          'CustomObject:Account,ApexPage:Foo'
+        )
+      ).to.deep.equal([
+        { type: 'CustomObject', fullName: 'Account' },
+        { type: 'ApexPage', fullName: 'Foo' }
+      ]);
+    });
+    it.skip('parses new-line delimited metadata component names from STDIN', async () => {
+      process.stdin.isTTY = false;
+      const promise = getMetadataComponentsFromStdinOrString('-');
+      process.stdin.push('CustomObject:Account');
+      process.stdin.push('ApexPage:Foo');
+      process.stdin.emit('end');
+      await new Promise((resolve) => setTimeout(resolve, 1000));
+      expect(await promise).to.deep.equal([
+        { type: 'CustomObject', fullName: 'Account' },
+        { type: 'ApexPage', fullName: 'Foo' }
+      ]);
+    });
+  });
+});

yarn.lock

@@ -3259,6 +3259,11 @@ get-package-type@^0.1.0:
   resolved "https://registry.yarnpkg.com/get-package-type/-/get-package-type-0.1.0.tgz#8de2d803cff44df3bc6c456e6668b36c3926e11a"
   integrity sha512-pjzuKtY64GYfWizNAJ0fr9VqttZkNiK2iS430LtIHzjBEr6bX8Am2zm4sW4Ro5wjWW5cAlRL1qAMTcXbjNAO2Q==
 
+[email protected]:
+  version "8.0.0"
+  resolved "https://registry.yarnpkg.com/get-stdin/-/get-stdin-8.0.0.tgz#cbad6a73feb75f6eeb22ba9e01f89aa28aa97a53"
+  integrity sha512-sY22aA6xchAzprjyqmSEQv4UbAAzRN0L2dQB0NlN5acTTK9Don6nhoc3eAbUnpZiCANAMfd/+40kVdKfFygohg==
+
 get-stdin@^4.0.1:
   version "4.0.1"
   resolved "https://registry.yarnpkg.com/get-stdin/-/get-stdin-4.0.1.tgz#b968c6b0a04384324902e8bf1a5df32579a450fe"