remove presettled messages from outgoing buffer once transferred

Author: grs

lib/session.js

@@ -236,6 +236,9 @@ Outgoing.prototype.process = function() {
                         var more = (i+1) < d.data.length;
                         var transfer = frames.transfer({'handle':d.link.local.handle,'message_format':d.format,'delivery_id':d.id, 'delivery_tag':d.tag, 'settled':d.settled, 'more':more});
                         d.link.session.output(transfer, d.data[i]);
+                        if (d.settled) {
+                            d.remote_settled = true;//if sending presettled, it can now be cleaned up
+                        }
                     }
                     d.link.credit--;
                     d.link.delivery_count++;

test/links.ts

@@ -721,4 +721,40 @@ describe('miscellaneous', function() {
         var conn = client.connect({port: (listener.address() as any).port, id: 'client'});
         conn.open_receiver();
     });
+
+    it('removes presettled messages from outgoing buffer', function(done: Function) {
+        var outgoing = [] as any;
+        var incoming = [] as any;
+        var sent = 0;
+        var settled = 0;
+        for (var i = 0; i < 10000; i++) {
+            outgoing.push('message-' + i);
+        }
+        server.on('message', function (context: rhea.EventContext) {
+            incoming.push(context.message!.body);
+        });
+        var conn = client.connect(listener.address() as any);
+        var s = conn.open_sender({snd_settle_mode:1});
+        s.on('sendable', function (context: rhea.EventContext) {
+            if (sent === 0) {
+                context.sender!.send({body:outgoing[sent++]});
+                context.connection.open_sender();
+            }
+        });
+        client.on('sendable', function (context: rhea.EventContext) {
+            while (context.sender!.sendable() && sent < outgoing.length) {
+                context.sender!.send({body:outgoing[sent++]});
+            }
+        });
+        client.on('settled', function (context: rhea.EventContext) {
+            settled++
+            if (settled === (outgoing.length - 1)) {
+                context.connection.close();
+            }
+        });
+        client.on('connection_close', function (context: rhea.EventContext) {
+            assert.deepEqual(incoming, outgoing);
+            done();
+        });
+    });
 });