Skip to content

Commit 5ad0778

Browse files
denysvitaliamol-verma-allen
authored andcommitted
Add pprof extension (jaegertracing#7073)
## Which problem is this PR solving? Currently it's not possible to profile Jaeger. This makes it hard to find bugs, memory leaks or problems in the running application. It looks like this was somehow supported in Jaeger v1 (I found references there) and was mentioned in `config.yaml` - but it didn't work out of the box because the extension was missing. ## Description of the changes This PR adds the [pprof](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/extension/pprofextension/README.md) ## How was this change tested? Using `all-in-one.yaml` and connecting to `localhost:17777` ## Checklist - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [X] I have signed all commits - [ ] I have added unit tests for the new functionality - [X] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Denys Vitali <[email protected]>
1 parent dbcecdd commit 5ad0778

File tree

4 files changed

+10
-4
lines changed

4 files changed

+10
-4
lines changed

cmd/jaeger/config.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
service:
2-
extensions: [jaeger_storage, jaeger_query, remote_sampling, healthcheckv2]
2+
extensions: [jaeger_storage, jaeger_query, remote_sampling, healthcheckv2, pprof]
33
pipelines:
44
traces:
55
receivers: [otlp, jaeger, zipkin]
@@ -26,8 +26,8 @@ extensions:
2626
use_v2: true
2727
http:
2828

29-
# pprof:
30-
# endpoint: 0.0.0.0:1777
29+
pprof:
30+
endpoint: 0.0.0.0:1777
3131
# zpages:
3232
# endpoint: 0.0.0.0:55679
3333

cmd/jaeger/internal/components.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import (
88
"github.com/open-telemetry/opentelemetry-collector-contrib/exporter/kafkaexporter"
99
"github.com/open-telemetry/opentelemetry-collector-contrib/exporter/prometheusexporter"
1010
"github.com/open-telemetry/opentelemetry-collector-contrib/extension/healthcheckv2extension"
11+
"github.com/open-telemetry/opentelemetry-collector-contrib/extension/pprofextension"
1112
"github.com/open-telemetry/opentelemetry-collector-contrib/processor/attributesprocessor"
1213
"github.com/open-telemetry/opentelemetry-collector-contrib/processor/tailsamplingprocessor"
1314
"github.com/open-telemetry/opentelemetry-collector-contrib/receiver/jaegerreceiver"
@@ -65,8 +66,10 @@ func (b builders) build() (otelcol.Factories, error) {
6566

6667
factories.Extensions, err = b.extension(
6768
// standard
68-
zpagesextension.NewFactory(),
6969
healthcheckv2extension.NewFactory(),
70+
pprofextension.NewFactory(),
71+
zpagesextension.NewFactory(),
72+
7073
// add-ons
7174
jaegerquery.NewFactory(),
7275
jaegerstorage.NewFactory(),

go.mod

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ require (
2626
github.com/open-telemetry/opentelemetry-collector-contrib/exporter/kafkaexporter v0.124.1
2727
github.com/open-telemetry/opentelemetry-collector-contrib/exporter/prometheusexporter v0.124.1
2828
github.com/open-telemetry/opentelemetry-collector-contrib/extension/healthcheckv2extension v0.124.1
29+
github.com/open-telemetry/opentelemetry-collector-contrib/extension/pprofextension v0.124.1
2930
github.com/open-telemetry/opentelemetry-collector-contrib/extension/storage v0.124.1
3031
github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/jaeger v0.124.1
3132
github.com/open-telemetry/opentelemetry-collector-contrib/processor/attributesprocessor v0.124.1

go.sum

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -453,6 +453,8 @@ github.com/open-telemetry/opentelemetry-collector-contrib/exporter/prometheusexp
453453
github.com/open-telemetry/opentelemetry-collector-contrib/exporter/prometheusexporter v0.124.1/go.mod h1:TfyVmHau1rTcA43Otjqme+hiWmrSrcnDEhQ4IDxLxF0=
454454
github.com/open-telemetry/opentelemetry-collector-contrib/extension/healthcheckv2extension v0.124.1 h1:L+pvmO01BWoe1qf+d/D9N/BnkTTmkSrWtxgyJ9zLWDI=
455455
github.com/open-telemetry/opentelemetry-collector-contrib/extension/healthcheckv2extension v0.124.1/go.mod h1:KwKZWApFx6/jVzt5+qyR5DJ11b2STZO7jMCrfiNbzHQ=
456+
github.com/open-telemetry/opentelemetry-collector-contrib/extension/pprofextension v0.124.1 h1:46evS2baudLPanhtLY3r0S96UTihfQo825T0vGxN8kE=
457+
github.com/open-telemetry/opentelemetry-collector-contrib/extension/pprofextension v0.124.1/go.mod h1:b2oVJgWayzhUbFlwG9tofHl6qfe/fhXUBvQm7kiCJVw=
456458
github.com/open-telemetry/opentelemetry-collector-contrib/extension/storage v0.124.1 h1:e9dmSpNCOWLyFnyUhqMzJLxVTMjbDzcnQCY1bmBvGr8=
457459
github.com/open-telemetry/opentelemetry-collector-contrib/extension/storage v0.124.1/go.mod h1:eMV7NsnkT+i5HZDQEAA/EtrM+ZhEOA5pkdLHvQ7X4Co=
458460
github.com/open-telemetry/opentelemetry-collector-contrib/internal/common v0.124.1 h1:cFu3VtuWdwvD1ftvTXH3v4Rm+be3BBhCz1OwiKoUQN0=

0 commit comments

Comments
 (0)