You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[chore] Remove gogoproto annotations from trace_storage.proto and dependency_storage.proto (jaegertracing#6819)
<!--
!! Please DELETE this comment before posting.
We appreciate your contribution to the Jaeger project! 👋🎉
-->
## Which problem is this PR solving?
- Towards jaegertracing#6789
## Description of the changes
- This PR removes the gogoproto annotations from `trace_storage.proto`
and `dependency_storage.proto` to avoid introducing a dependency on gogo
for users. Instead, it uses a similar patching mechanism to api_v3 to
add the annotations when generating the *.pb.go files.
## How was this change tested?
- CI
## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
- for `jaeger`: `make lint test`
- for `jaeger-ui`: `npm run lint` and `npm run test`
---------
Signed-off-by: Mahad Zaryab <[email protected]>
0 commit comments