Skip to content

Commit 14cd2b9

Browse files
jinjiaKarlamol-verma-allen
authored andcommitted
Make dco check email case-insensitive (jaegertracing#6849)
## Which problem is this PR solving? - Resolves jaegertracing#6846 ## Description of the changes - ## How was this change tested? - ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: jinjia <[email protected]> Signed-off-by: amol-verma-allen <[email protected]>
1 parent 7094051 commit 14cd2b9

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

scripts/lint/dco_check.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1071,10 +1071,10 @@ def process_commits(
10711071
if not is_valid_email(email):
10721072
infractions[commit.hash].append(f'invalid email: {email}')
10731073
else:
1074-
sign_offs_name_email.append((name, email))
1074+
sign_offs_name_email.append((name, email.lower()))
10751075

10761076
# Check that author is in the sign-offs
1077-
if not (commit.author_name, commit.author_email) in sign_offs_name_email:
1077+
if not (commit.author_name, commit.author_email.lower()) in sign_offs_name_email:
10781078
infractions[commit.hash].append(
10791079
'sign-off not found for commit author: '
10801080
f'{commit.author_name} {commit.author_email}; found: {sign_offs}'

0 commit comments

Comments
 (0)