Merge pull request #48 from alexislefebvre/feature/45-allow-280-characters-per-tweet

Feature: Fixes #45: Allow 280 characters per tweet

Author: alexislefebvre

DataFixtures/ORM/LoadTweetData.php

@@ -83,6 +83,21 @@ public function load(ObjectManager $manager)
 
         $manager->persist($tweet);
         $manager->flush();
+
+        // 280 characters
+        $tweet = new Tweet();
+        $tweet
+            ->setId(928032273747795968)
+            ->setUser($this->getReference('user'))
+            ->setCreatedAt(new \Datetime('2017-11-08 21:20:00'))
+            ->setText('In the criminal justice system, sexually based offenses are considered especially heinous. '.
+                'In New York City, the dedicated detectives who investigate these vicious felonies are members of '.
+                'an elite squad known as the Special Victims Unit. These are their stories. *DUN DUN*️')
+            ->setRetweetCount(144416)
+            ->setFavoriteCount(256453);
+
+        $manager->persist($tweet);
+        $manager->flush();
     }
 
     /**

DataFixtures/ORM/LoadUserData.php

@@ -38,7 +38,7 @@ public function load(ObjectManager $manager)
 
         $this->addReference('user-github', $user);
 
-        // Use whose tweet is retweeted
+        // User whose tweet is retweeted
         $user = new User();
         $user
             ->setId(131295561)

Resources/config/doctrine/Tweet.orm.yml

@@ -19,7 +19,7 @@ AlexisLefebvre\Bundle\AsyncTweetsBundle\Entity\Tweet:
             length: null
         text:
             type: string
-            length: '255'
+            length: '280'
         retweet_count:
             type: integer
             length: null

Tests/Command/StatusesHomeTimelineTest.php

@@ -255,6 +255,12 @@ public function testStatusesHomeTimelineWithTweetAndRetweet()
         );
     }
 
+    /**
+     * @requires OS Linux
+     *
+     * It returns “last tweet = 928032273747800064” on Windows (AppVeyor),
+     * this is equal to 928032273747795968+4096, it looks like a bug on Windows.
+     */
     public function testStatusesHomeTimelineWithSinceIdParameter()
     {
         $this->loadFixtures([
@@ -264,12 +270,6 @@ public function testStatusesHomeTimelineWithSinceIdParameter()
         // Disable decoration for tests on Windows
         $options = [];
 
-        // http://stackoverflow.com/questions/5879043/php-script-detect-whether-running-under-linux-or-windows/5879078#5879078
-        if (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') {
-            // https://tracker.phpbb.com/browse/PHPBB3-12752
-            $options['decorated'] = false;
-        }
-
         $this->commandTester->execute(
             ['test' => 'empty_array'],
             $options
@@ -278,7 +278,7 @@ public function testStatusesHomeTimelineWithSinceIdParameter()
         $display = $this->commandTester->getDisplay();
 
         $this->assertContains(
-            'last tweet = 1005868490',
+            'last tweet = 928032273747795968',
             $display
         );
     }

Tests/Entity/TweetRepositoryTest.php

@@ -49,4 +49,20 @@ public function testTweetRepository()
 
         $this->assertEquals(3, $tweets);
     }
+
+    public function testTweetRepositoryWithLongTweet()
+    {
+        $this->loadFixtures([
+            'AlexisLefebvre\Bundle\AsyncTweetsBundle\DataFixtures\ORM\LoadTweetData',
+        ]);
+
+        /** @var Tweet $tweet */
+        $tweet = $this->em
+            ->getRepository('AsyncTweetsBundle:Tweet')
+            ->findOneBy(['id' => 928032273747795968]);
+
+        $this->assertNotNull($tweet);
+
+        $this->assertSame(275, strlen($tweet->getText()));
+    }
 }