[chore]: fix testifylint rules discovered with golangci-lint@v2 (open-telemetry#39271)

#### Description

Fixes testifylint rules discovered with golangci-lint@v2

---------

Signed-off-by: Matthieu MOREL <[email protected]>

Author: mmorel-35

.golangci.yml

@@ -198,12 +198,9 @@ linters:
 
     testifylint:
       disable:
-        - empty # FIXME
         - encoded-compare # has false positives that cannot be fixed with testifylint-fix
         - equal-values # FIXME
         - float-compare
-        - formatter # FIXME
-        - len # FIXME
         - require-error
         - suite-subtest-run
         - useless-assert # FIXME when golangci-lint > 2.0.2

exporter/signalfxexporter/internal/apm/requests/requestcounter/counter_test.go

@@ -46,6 +46,6 @@ func TestContextWithRequestCounter(t *testing.T) {
 	todo := context.TODO()
 	assert.False(t, counterExists(todo), "plain context shouldn't have a counter")
 	assert.Equal(t, uint32(0), GetRequestCount(todo), "plain context should return count of 0")
-	assert.NotPanics(t, func() { IncrementRequestCount(todo) }, todo, "incrementing a plain counter should not panic")
+	assert.NotPanics(t, func() { IncrementRequestCount(todo) }, "incrementing a plain counter should not panic")
 	assert.Equal(t, uint32(0), GetRequestCount(todo), "incrementing a plain counter should do nothing")
 }

exporter/sumologicexporter/sender_test.go

@@ -987,7 +987,7 @@ func TestSendCompressGzip(t *testing.T) {
 			res.WriteHeader(http.StatusOK)
 			if _, err := res.Write([]byte("")); err != nil {
 				res.WriteHeader(http.StatusInternalServerError)
-				assert.Fail(t, "err: %v", err)
+				assert.Fail(t, err.Error())
 				return
 			}
 			body := decodeGzip(t, req.Body)
@@ -1008,7 +1008,7 @@ func TestSendCompressGzipDeprecated(t *testing.T) {
 			res.WriteHeader(http.StatusOK)
 			if _, err := res.Write([]byte("")); err != nil {
 				res.WriteHeader(http.StatusInternalServerError)
-				assert.Fail(t, "err: %v", err)
+				assert.Fail(t, err.Error())
 				return
 			}
 			body := decodeGzip(t, req.Body)
@@ -1029,7 +1029,7 @@ func TestSendCompressZstd(t *testing.T) {
 			res.WriteHeader(http.StatusOK)
 			if _, err := res.Write([]byte("")); err != nil {
 				res.WriteHeader(http.StatusInternalServerError)
-				assert.Fail(t, "err: %v", err)
+				assert.Fail(t, err.Error())
 				return
 			}
 			body := decodeZstd(t, req.Body)
@@ -1050,7 +1050,7 @@ func TestSendCompressDeflate(t *testing.T) {
 			res.WriteHeader(http.StatusOK)
 			if _, err := res.Write([]byte("")); err != nil {
 				res.WriteHeader(http.StatusInternalServerError)
-				assert.Fail(t, "err: %v", err)
+				assert.Fail(t, err.Error())
 				return
 			}
 			body := decodeZlib(t, req.Body)

pkg/core/xidutils/big_endian_converter_test.go

@@ -27,7 +27,6 @@ func TestUInt64ToTraceIDConversion(t *testing.T) {
 	assert.Equal(t,
 		UInt64ToTraceID(5, 0),
 		pcommon.TraceID([16]byte{0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x05, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}),
-		UInt64ToTraceID(5, 0),
 		"Failed to convert 0 low:")
 	assert.Equal(t,
 		pcommon.TraceID([16]byte{0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x05}),

pkg/stanza/operator/input/tcp/input_test.go

@@ -5,6 +5,7 @@ package tcp
 
 import (
 	"crypto/tls"
+	"fmt"
 	"math/rand/v2"
 	"net"
 	"os"
@@ -117,7 +118,7 @@ func tcpInputTest(input []byte, expected []string) func(t *testing.T) {
 
 		select {
 		case entry := <-entryChan:
-			require.FailNow(t, "Unexpected entry: %s", entry)
+			require.FailNow(t, fmt.Sprintf("Unexpected entry: %s", entry))
 		case <-time.After(100 * time.Millisecond):
 			return
 		}
@@ -183,7 +184,7 @@ func tcpInputAttributesTest(input []byte, expected []string) func(t *testing.T)
 
 		select {
 		case entry := <-entryChan:
-			require.FailNow(t, "Unexpected entry: %s", entry)
+			require.FailNow(t, fmt.Sprintf("Unexpected entry: %s", entry))
 		case <-time.After(100 * time.Millisecond):
 			return
 		}
@@ -254,7 +255,7 @@ func tlsInputTest(input []byte, expected []string) func(t *testing.T) {
 
 		select {
 		case entry := <-entryChan:
-			require.FailNow(t, "Unexpected entry: %s", entry)
+			require.FailNow(t, fmt.Sprintf("Unexpected entry: %s", entry))
 		case <-time.After(100 * time.Millisecond):
 			return
 		}

pkg/stanza/operator/input/udp/input_test.go

@@ -4,6 +4,7 @@
 package udp
 
 import (
+	"fmt"
 	"math/rand/v2"
 	"net"
 	"strconv"
@@ -61,7 +62,7 @@ func udpInputTest(input []byte, expected []string, cfg *Config) func(t *testing.
 
 		select {
 		case entry := <-entryChan:
-			require.FailNow(t, "Unexpected entry: %s", entry)
+			require.FailNow(t, fmt.Sprintf("Unexpected entry: %s", entry))
 		case <-time.After(100 * time.Millisecond):
 			return
 		}
@@ -131,7 +132,7 @@ func udpInputAttributesTest(input []byte, expected []string) func(t *testing.T)
 
 		select {
 		case entry := <-entryChan:
-			require.FailNow(t, "Unexpected entry: %s", entry)
+			require.FailNow(t, fmt.Sprintf("Unexpected entry: %s", entry))
 		case <-time.After(100 * time.Millisecond):
 			return
 		}

pkg/translator/prometheus/normalize_label_test.go

@@ -14,7 +14,7 @@ import (
 func TestSanitize(t *testing.T) {
 	defer testutil.SetFeatureGateForTest(t, dropSanitizationGate, false)()
 
-	require.Empty(t, NormalizeLabel(""), "")
+	require.Empty(t, NormalizeLabel(""))
 	require.Equal(t, "key_test", NormalizeLabel("_test"))
 	require.Equal(t, "key_0test", NormalizeLabel("0test"))
 	require.Equal(t, "test", NormalizeLabel("test"))

processor/transformprocessor/internal/metrics/func_convert_exponential_hist_to_explicit_hist_test.go

@@ -728,7 +728,7 @@ func TestRandom_convert_exponential_hist_to_explicit_hist(t *testing.T) {
 				// since the max value in the exponential histogram is 245
 				// we can assert that the overflow bucket has a count > 0
 				overflow := dp.BucketCounts().At(dp.BucketCounts().Len() - 1)
-				assert.Positive(t, overflow, uint64(0), "overflow bucket count should be > 0")
+				assert.Positive(t, overflow, "overflow bucket count should be > 0")
 				return
 			}
 

receiver/awscontainerinsightreceiver/internal/host/ebsvolume_test.go

@@ -205,7 +205,7 @@ func TestExtractEbsIDsUsedByKubernetes(t *testing.T) {
 
 			ebsIDs := e.extractEbsIDsUsedByKubernetes()
 
-			assert.Equal(t, test.expectedVolumeCount, len(ebsIDs))
+			assert.Len(t, ebsIDs, test.expectedVolumeCount)
 			if test.expectedVolumeCount > 0 {
 				assert.Equal(t, test.expected, ebsIDs[test.devPath])
 			}

receiver/tlscheckreceiver/scraper_test.go

@@ -145,7 +145,7 @@ func TestScrape_ExpiredEndpointCertificate(t *testing.T) {
 
 	// Ensure that timeLeft is negative for an expired cert
 	timeLeft := dp.IntValue()
-	assert.Negative(t, timeLeft, int64(0), "Time left should be negative for an expired certificate")
+	assert.Negative(t, timeLeft, "Time left should be negative for an expired certificate")
 }
 
 func TestScrape_NotYetValidEndpointCertificate(t *testing.T) {