Skip to content

Commit 166464a

Browse files
committed
chore: remove embedded settings page from webapp (#17643)
1 parent a935eff commit 166464a

File tree

8 files changed

+1
-159
lines changed

8 files changed

+1
-159
lines changed

airbyte-webapp/src/packages/cloud/views/routes/WorkspacesRoutes.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ import {
2626
SourcesPage as SettingsSourcesPage,
2727
DestinationsPage as SettingsDestinationsPage,
2828
} from "pages/SettingsPage/pages/ConnectorsPage";
29-
import { EmbeddedSettingsPage } from "pages/SettingsPage/pages/EmbbededSettingsPage/EmbeddedSettingsPage";
3029
import { NotificationPage } from "pages/SettingsPage/pages/NotificationPage";
3130
import { GeneralOrganizationSettingsPage } from "pages/SettingsPage/pages/Organization/GeneralOrganizationSettingsPage";
3231
import { OrganizationMembersPage } from "pages/SettingsPage/pages/Organization/OrganizationMembersPage";
@@ -108,7 +107,6 @@ export const WorkspacesRoutes: React.FC = () => {
108107
<Route path={CloudSettingsRoutePaths.Source} element={<SettingsSourcesPage />} />
109108
<Route path={CloudSettingsRoutePaths.Destination} element={<SettingsDestinationsPage />} />
110109
<Route path={CloudSettingsRoutePaths.Notifications} element={<NotificationPage />} />
111-
<Route path={SettingsRoutePaths.Embedded} element={<EmbeddedSettingsPage />} />
112110
{supportsCloudDbtIntegration && (
113111
<Route path={CloudSettingsRoutePaths.DbtCloud} element={<DbtCloudSettingsView />} />
114112
)}

airbyte-webapp/src/packages/cloud/views/settings/CloudSettingsPage.tsx

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ export const CloudSettingsPage: React.FC = () => {
2727
const showAdvancedSettings = useExperiment("settings.showAdvancedSettings");
2828
const canManageOrganizationBilling = useGeneratedIntent(Intent.ManageOrganizationBilling);
2929
const canViewOrganizationUsage = useGeneratedIntent(Intent.ViewOrganizationUsage);
30-
const canManageEmbedded = useIntent("CreateConfigTemplate", { organizationId: workspace.organizationId });
31-
const allowConfigTemplateEndpoints = useExperiment("platform.allow-config-template-endpoints");
3230
const showOrgPicker = useExperiment("sidebar.showOrgPicker");
3331

3432
return (
@@ -41,13 +39,6 @@ export const CloudSettingsPage: React.FC = () => {
4139
name={formatMessage({ id: "settings.account" })}
4240
to={CloudSettingsRoutePaths.Account}
4341
/>
44-
{canManageEmbedded && allowConfigTemplateEndpoints && (
45-
<SettingsLink
46-
iconType="stars"
47-
name={formatMessage({ id: "settings.embedded" })}
48-
to={CloudSettingsRoutePaths.Embedded}
49-
/>
50-
)}
5142
<SettingsLink
5243
iconType="grid"
5344
name={formatMessage({ id: "settings.applications" })}

airbyte-webapp/src/packages/cloud/views/settings/routePaths.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,4 @@ export const CloudSettingsRoutePaths = {
1515
OrganizationMembers: SettingsRoutePaths.OrganizationMembers,
1616
DbtCloud: "dbt-cloud",
1717
Applications: SettingsRoutePaths.Applications,
18-
Embedded: "embedded",
1918
} as const;

airbyte-webapp/src/pages/SettingsPage/OrganizationSettingsPage.tsx

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,8 @@ import { SettingsLink, SettingsNavigation, SettingsNavigationBlock } from "area/
1010
import { FeatureItem, useFeature } from "core/services/features";
1111
import { useIsCloudApp } from "core/utils/app";
1212
import { Intent, useGeneratedIntent, useIntent } from "core/utils/rbac";
13-
import { useExperiment } from "hooks/services/Experiment";
1413
import { CloudSettingsRoutePaths } from "packages/cloud/views/settings/routePaths";
15-
import { RoutePaths, SettingsRoutePaths } from "pages/routePaths";
14+
import { SettingsRoutePaths } from "pages/routePaths";
1615

1716
export const OrganizationSettingsPage: React.FC = () => {
1817
const { formatMessage } = useIntl();
@@ -22,8 +21,6 @@ export const OrganizationSettingsPage: React.FC = () => {
2221
const canViewOrganizationSettings = useIntent("ViewOrganizationSettings", { organizationId });
2322
const canManageOrganizationBilling = useGeneratedIntent(Intent.ManageOrganizationBilling, { organizationId });
2423
const canViewOrganizationUsage = useGeneratedIntent(Intent.ViewOrganizationUsage, { organizationId });
25-
const canManageEmbedded = useIntent("CreateConfigTemplate", { organizationId });
26-
const allowConfigTemplateEndpoints = useExperiment("platform.allow-config-template-endpoints");
2724
const isCloudApp = useIsCloudApp();
2825

2926
return (
@@ -59,13 +56,6 @@ export const OrganizationSettingsPage: React.FC = () => {
5956
to={CloudSettingsRoutePaths.OrganizationUsage}
6057
/>
6158
)}
62-
{isCloudApp && canManageEmbedded && allowConfigTemplateEndpoints && (
63-
<SettingsLink
64-
iconType="stars"
65-
name={formatMessage({ id: "settings.embedded" })}
66-
to={`${RoutePaths.Settings}/${CloudSettingsRoutePaths.Embedded}`}
67-
/>
68-
)}
6959
</SettingsNavigationBlock>
7060
</SettingsNavigation>
7161
<SettingsLayoutContent>

airbyte-webapp/src/pages/SettingsPage/pages/EmbbededSettingsPage/EmbeddedSettingsPage.module.scss

Lines changed: 0 additions & 32 deletions
This file was deleted.

airbyte-webapp/src/pages/SettingsPage/pages/EmbbededSettingsPage/EmbeddedSettingsPage.tsx

Lines changed: 0 additions & 86 deletions
This file was deleted.

0 commit comments

Comments
 (0)