Skip to content

Commit b3fccc0

Browse files
authored
Update: replace dialog button aria-expanded with aria-haspopup dialog (fixes #251)
1 parent 83e7e46 commit b3fccc0

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

js/PageLevelProgressNavigationView.js

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ export default class PageLevelProgressNavigationView extends NavigationButtonVie
2323
role: attributes._role === 'button' ? undefined : attributes._role,
2424
'data-order': attributes._order,
2525
'data-tooltip-id': 'pagelevelprogress',
26-
'aria-expanded': false
26+
'aria-haspopup': 'dialog'
2727
};
2828
}
2929

@@ -53,8 +53,7 @@ export default class PageLevelProgressNavigationView extends NavigationButtonVie
5353
this.listenTo(Adapt, {
5454
remove: this.remove,
5555
'router:location': this.updateProgressBar,
56-
'view:childAdded pageLevelProgress:update': this.refreshProgressBar,
57-
'drawer:closed': this.drawerClosed
56+
'view:childAdded pageLevelProgress:update': this.refreshProgressBar
5857
});
5958
this.listenTo(data, 'change:_isLocked change:_isVisible change:_isComplete', this.refreshProgressBar);
6059
}
@@ -99,13 +98,8 @@ export default class PageLevelProgressNavigationView extends NavigationButtonVie
9998
this.updateProgressBar();
10099
}
101100

102-
drawerClosed() {
103-
this.$el.attr('aria-expanded', false);
104-
}
105-
106101
onProgressClicked(event) {
107102
if (event && event.preventDefault) event.preventDefault();
108-
this.$el.attr('aria-expanded', true);
109103
drawer.openCustomView(new PageLevelProgressView({
110104
collection: this.collection
111105
}).$el, false, this.model.get('_drawerPosition'));

0 commit comments

Comments
 (0)