Skip to content

Commit b38a161

Browse files
committed
Upload coverage results on PHP8
1 parent dc7c31e commit b38a161

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

.github/workflows/tests.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,7 @@ jobs:
6464

6565
# https://github.com/php-coveralls/php-coveralls#github-actions
6666
- name: Upload coverage results to Coveralls
67-
# NOTE: For now we would run this step only on php7.4 due to the error on php8.
68-
# https://github.com/ackintosh/ganesha/runs/4375377952?check_suite_focus=true
69-
# > PHP Fatal error: Declaration of PhpCoveralls\Bundle\CoverallsBundle\Console\Application::getDefinition() must be compatible with ...
70-
if: ${{ matrix.php-version == '7.4' }}
67+
if: ${{ matrix.php-version == '8.0' }}
7168
env:
7269
COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
7370
run: |

0 commit comments

Comments
 (0)