Skip to content

Commit 3831438

Browse files
authored
Raise NotImplementedError instead of returning it (#158)
* Raise NotImplementedError instead of returning it Signed-off-by: Jono Yang <[email protected]> * Update CHANGELOG.rst Signed-off-by: Jono Yang <[email protected]> --------- Signed-off-by: Jono Yang <[email protected]>
1 parent 50f83d1 commit 3831438

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

CHANGELOG.rst

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
Changelog
22
=========
33

4+
Version v31.0.0
5+
----------------
6+
7+
- Raise instead of returning ``NotImplementedError`` in ``version_range.VersionRange`` methods. https://github.com/aboutcode-org/univers/pull/158
8+
49
Version v30.12.1
510
----------------
611

src/univers/version_range.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,15 +78,15 @@ def from_native(cls, string):
7878
Return a VersionRange built from a scheme-specific, native version range
7979
``string``. Subclasses can implement.
8080
"""
81-
return NotImplementedError
81+
raise NotImplementedError
8282

8383
@classmethod
8484
def from_natives(cls, strings):
8585
"""
8686
Return a VersionRange built from a ``strings`` list of scheme-
8787
specific native version range strings. Subclasses can implement.
8888
"""
89-
return NotImplementedError
89+
raise NotImplementedError
9090

9191
def to_native(self, *args, **kwargs):
9292
"""
@@ -95,7 +95,7 @@ def to_native(self, *args, **kwargs):
9595
extra arguments (such as a package name that some scheme may require
9696
like for deb and rpm.)
9797
"""
98-
return NotImplementedError
98+
raise NotImplementedError
9999

100100
@classmethod
101101
def from_string(cls, vers, simplify=False, validate=False):
@@ -176,7 +176,7 @@ def from_versions(cls, sequence):
176176
such as ["3.0.0", "1.0.1b", "3.0.2", "0.9.7a", "1.1.1ka"]
177177
"""
178178
if not cls.scheme or not cls.version_class:
179-
return NotImplementedError
179+
raise NotImplementedError
180180

181181
constraints = []
182182
for version in sequence:

0 commit comments

Comments
 (0)