fix: change SLA deadline fields to use nullable types

Author: abhinavxd

internal/sla/models/models.go

@@ -75,8 +75,8 @@ type AppliedSLA struct {
 	Status                  string    `db:"status"`
 	ConversationID          int       `db:"conversation_id"`
 	SLAPolicyID             int       `db:"sla_policy_id"`
-	FirstResponseDeadlineAt time.Time `db:"first_response_deadline_at"`
-	ResolutionDeadlineAt    time.Time `db:"resolution_deadline_at"`
+	FirstResponseDeadlineAt null.Time `db:"first_response_deadline_at"`
+	ResolutionDeadlineAt    null.Time `db:"resolution_deadline_at"`
 	FirstResponseBreachedAt null.Time `db:"first_response_breached_at"`
 	ResolutionBreachedAt    null.Time `db:"resolution_breached_at"`
 	FirstResponseMetAt      null.Time `db:"first_response_met_at"`

internal/sla/sla.go

@@ -617,10 +617,10 @@ func (m *Manager) SendNotification(scheduledNotification models.ScheduledSLANoti
 
 		switch scheduledNotification.Metric {
 		case MetricFirstResponse:
-			dueIn = getFriendlyDuration(appliedSLA.FirstResponseDeadlineAt)
+			dueIn = getFriendlyDuration(appliedSLA.FirstResponseDeadlineAt.Time)
 			overdueBy = getFriendlyDuration(appliedSLA.FirstResponseBreachedAt.Time)
 		case MetricResolution:
-			dueIn = getFriendlyDuration(appliedSLA.ResolutionDeadlineAt)
+			dueIn = getFriendlyDuration(appliedSLA.ResolutionDeadlineAt.Time)
 			overdueBy = getFriendlyDuration(appliedSLA.ResolutionBreachedAt.Time)
 		case MetricNextResponse:
 			dueIn = getFriendlyDuration(slaEvent.DeadlineAt)
@@ -828,7 +828,7 @@ func (m *Manager) evaluateSLA(sla models.AppliedSLA) error {
 	m.lo.Debug("evaluating SLA", "conversation_id", sla.ConversationID, "applied_sla_id", sla.ID)
 	checkDeadline := func(deadline time.Time, metAt null.Time, metric string) error {
 		if deadline.IsZero() {
-			m.lo.Warn("deadline zero, skipping checking the deadline")
+			m.lo.Warn("deadline zero, skipping checking the deadline", "conversation_id", sla.ConversationID, "applied_sla_id", sla.ID, "metric", metric)
 			return nil
 		}
 
@@ -860,15 +860,15 @@ func (m *Manager) evaluateSLA(sla models.AppliedSLA) error {
 	// If first response is not breached and not met, check the deadline and set them.
 	if !sla.FirstResponseBreachedAt.Valid && !sla.FirstResponseMetAt.Valid {
 		m.lo.Debug("checking deadline", "deadline", sla.FirstResponseDeadlineAt, "met_at", sla.ConversationFirstResponseAt.Time, "metric", MetricFirstResponse)
-		if err := checkDeadline(sla.FirstResponseDeadlineAt, sla.ConversationFirstResponseAt, MetricFirstResponse); err != nil {
+		if err := checkDeadline(sla.FirstResponseDeadlineAt.Time, sla.ConversationFirstResponseAt, MetricFirstResponse); err != nil {
 			return err
 		}
 	}
 
 	// If resolution is not breached and not met, check the deadine and set them.
 	if !sla.ResolutionBreachedAt.Valid && !sla.ResolutionMetAt.Valid {
 		m.lo.Debug("checking deadline", "deadline", sla.ResolutionDeadlineAt, "met_at", sla.ConversationResolvedAt.Time, "metric", MetricResolution)
-		if err := checkDeadline(sla.ResolutionDeadlineAt, sla.ConversationResolvedAt, MetricResolution); err != nil {
+		if err := checkDeadline(sla.ResolutionDeadlineAt.Time, sla.ConversationResolvedAt, MetricResolution); err != nil {
 			return err
 		}
 	}