fix: conversation list view filters, views do not need list status as views are already filtered.

Author: abhinavxd

frontend/src/stores/conversation.js

@@ -125,6 +125,10 @@ export const useConversationStore = defineStore('conversation', () => {
     }
   }
 
+  const getListStatus = computed(() => {
+    return conversations.status
+  })
+
   function setListSortField (field) {
     if (conversations.sortField === field) return
     conversations.sortField = field
@@ -136,9 +140,6 @@ export const useConversationStore = defineStore('conversation', () => {
     return sortFieldLabels[conversations.sortField]
   })
 
-  const getListStatus = computed(() => {
-    return conversations.status
-  })
 
   async function fetchStatuses () {
     if (statuses.value.length > 0) return
@@ -174,11 +175,14 @@ export const useConversationStore = defineStore('conversation', () => {
 
   const conversationsList = computed(() => {
     if (!conversations.data) return []
-    // Filter by status.
     let filteredConversations = conversations.data
-      .filter(conv => {
-        return conv.status === conversations.status
-      })
+    // Filter by status if set.
+    if (conversations.status !== "") {
+      filteredConversations = conversations.data
+        .filter(conv => {
+          return conv.status === conversations.status
+        })
+    }
 
     // Sort conversations based on the selected sort field
     return [...filteredConversations].sort((a, b) => {

frontend/src/views/inbox/InboxView.vue

@@ -21,12 +21,19 @@ const conversationStore = useConversationStore()
 onMounted(() => {
   // Fetch list based on type
   if (type.value) {
-    conversationStore.setListStatus(CONVERSATION_DEFAULT_STATUSES.OPEN, false)
+    // Set list status if not already set
+    if (!conversationStore.getListStatus) {
+      conversationStore.setListStatus(CONVERSATION_DEFAULT_STATUSES.OPEN, false)
+    }
     conversationStore.resetCurrentConversation()
     conversationStore.fetchConversationsList(true, type.value)
   }
   // Fetch team list.
   if (teamID.value) {
+    // Set list status if not already set
+    if (!conversationStore.getListStatus) {
+      conversationStore.setListStatus(CONVERSATION_DEFAULT_STATUSES.OPEN, false)
+    }
     conversationStore.resetCurrentConversation()
     conversationStore.fetchConversationsList(
       true,
@@ -36,6 +43,8 @@ onMounted(() => {
   }
   // Fetch view list.
   if (viewID.value) {
+    // Empty out list status as views are already filtered.
+    conversationStore.setListStatus('', false)
     conversationStore.resetCurrentConversation()
     conversationStore.fetchConversationsList(true, CONVERSATION_LIST_TYPE.VIEW, 0, [], viewID.value)
   }
@@ -46,16 +55,26 @@ watch(
   [type, teamID, viewID],
   ([newType, newTeamID, newViewID], [oldType, oldTeamID, oldViewID]) => {
     if (newType !== oldType && newType) {
+      // Set list status if not already set
+      if (!conversationStore.getListStatus) {
+        conversationStore.setListStatus(CONVERSATION_DEFAULT_STATUSES.OPEN, false)
+      }
       conversationStore.fetchConversationsList(true, newType)
     }
     if (newTeamID !== oldTeamID && newTeamID) {
+      // Set list status if not already set
+      if (!conversationStore.getListStatus) {
+        conversationStore.setListStatus(CONVERSATION_DEFAULT_STATUSES.OPEN, false)
+      }
       conversationStore.fetchConversationsList(
         true,
         CONVERSATION_LIST_TYPE.TEAM_UNASSIGNED,
         newTeamID
       )
     }
     if (newViewID !== oldViewID && newViewID) {
+      // Empty out list status as views are already filtered.
+      conversationStore.setListStatus('', false)
       conversationStore.fetchConversationsList(true, CONVERSATION_LIST_TYPE.VIEW, 0, [], newViewID)
     }
   }