fix: remove conflicting constraints on NOT NULL columns in applied_slas and csat_responses tables, update constraints for csat_responses and applied_slas tables to cascade deletes instead

Author: abhinavxd

internal/migrations/v0.6.0.go

@@ -86,16 +86,6 @@ func V0_6_0(db *sqlx.DB, fs stuffbin.FileSystem, ko *koanf.Koanf) error {
 		}
 	}
 
-	// Add `contacts:read` permission to Agent role
-	_, err = db.Exec(`
-		UPDATE roles
-		SET permissions = array_append(permissions, 'contacts:read')
-		WHERE name = 'Agent' AND NOT ('contacts:read' = ANY(permissions));
-	`)
-	if err != nil {
-		return err
-	}
-
 	// Add `custom_attributes:manage` permission to Admin role
 	_, err = db.Exec(`
 		UPDATE roles
@@ -311,5 +301,28 @@ func V0_6_0(db *sqlx.DB, fs stuffbin.FileSystem, ko *koanf.Koanf) error {
 	if err != nil {
 		return err
 	}
+
+	// Replace constraints for applied_slas and csat_responses tables.
+	_, err = db.Exec(`
+		ALTER TABLE applied_slas
+		DROP CONSTRAINT IF EXISTS applied_slas_conversation_id_fkey,
+		DROP CONSTRAINT IF EXISTS applied_slas_sla_policy_id_fkey,
+		ALTER COLUMN conversation_id SET NOT NULL,
+		ALTER COLUMN sla_policy_id   SET NOT NULL,
+		ADD CONSTRAINT applied_slas_conversation_id_fkey
+			FOREIGN KEY (conversation_id) REFERENCES conversations(id)
+			ON DELETE CASCADE ON UPDATE CASCADE,
+		ADD CONSTRAINT applied_slas_sla_policy_id_fkey
+			FOREIGN KEY (sla_policy_id) REFERENCES sla_policies(id)
+			ON DELETE CASCADE ON UPDATE CASCADE;
+
+
+		ALTER TABLE csat_responses
+		DROP CONSTRAINT IF EXISTS csat_responses_conversation_id_fkey,
+		ALTER COLUMN conversation_id SET NOT NULL,
+		ADD CONSTRAINT csat_responses_conversation_id_fkey
+		FOREIGN KEY (conversation_id) REFERENCES conversations(id) 
+			ON DELETE CASCADE ON UPDATE CASCADE;
+	`)
 	return nil
 }

schema.sql

@@ -415,8 +415,8 @@ CREATE TABLE csat_responses (
     updated_at TIMESTAMPTZ DEFAULT NOW(),
 	uuid UUID DEFAULT gen_random_uuid() NOT NULL UNIQUE,
 
-	-- Keep CSAT responses even if the conversation or agent is deleted.
-    conversation_id BIGINT REFERENCES conversations(id) ON DELETE SET NULL ON UPDATE CASCADE NOT NULL,
+	-- Cascade deletes when conversation is deleted.
+    conversation_id BIGINT REFERENCES conversations(id) ON DELETE CASCADE ON UPDATE CASCADE NOT NULL,
 
     rating INT DEFAULT 0 NOT NULL,
     feedback TEXT NULL,
@@ -447,9 +447,9 @@ CREATE TABLE applied_slas (
 
 	status applied_sla_status DEFAULT 'pending' NOT NULL,
 
-	-- Conversation / SLA policy maybe deleted but for reports the applied SLA should remain.
-	conversation_id BIGINT REFERENCES conversations(id) ON DELETE SET NULL ON UPDATE CASCADE NOT NULL,
-	sla_policy_id INT REFERENCES sla_policies(id) ON DELETE SET NULL ON UPDATE CASCADE NOT NULL,
+	-- Cascade deletes when conversation or SLA policy is deleted.
+	conversation_id BIGINT REFERENCES conversations(id) ON DELETE CASCADE ON UPDATE CASCADE NOT NULL,
+	sla_policy_id INT REFERENCES sla_policies(id) ON DELETE CASCADE ON UPDATE CASCADE NOT NULL,
 
 	first_response_deadline_at TIMESTAMPTZ NULL,
 	resolution_deadline_at TIMESTAMPTZ NULL,