Merge branch 'foldynl:master' into master

Author: aa5sh

Changelog

@@ -1,3 +1,6 @@
+2025/05/11 - 0.44.1
+- Fixed Rotator Widget Seg Fault for new users (issue #666)
+
 2025/05/09 - 0.44.0
 - [NEW] - Activity Manager - Added SKCC, UKSMG and FISTS as Dynamic Fields
 - [NEW] - QSO - FISTS, SKCC, and UKSMG are auto-filled from MembershipQE (issue #628)

QLog.pro

@@ -10,7 +10,7 @@ greaterThan(QT_MAJOR_VERSION, 5): QT += widgets
 
 TARGET = qlog
 TEMPLATE = app
-VERSION = 0.44.0
+VERSION = 0.44.1
 
 DEFINES += VERSION=\\\"$$VERSION\\\"
 

debian/changelog

@@ -1,3 +1,8 @@
+qlog (0.44.1-1) UNRELEASED; urgency=low
+  * Fixed Rotator Widget Seg Fault for new users (issue #666)
+
+ -- foldynl <[email protected]>  Sun, 11 May 2025 07:30:56 +0200
+
 qlog (0.44.0-1) UNRELEASED; urgency=low
   * [NEW] - Activity Manager - Added SKCC, UKSMG and FISTS as Dynamic Fields
   * [NEW] - QSO - FISTS, SKCC, and UKSMG are auto-filled from MembershipQE (issue #628)

installer/config/config.xml

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Installer>
     <Name>QLog</Name>
-    <Version>0.44.0</Version>
+    <Version>0.44.1</Version>
     <Title>QLog</Title>
     <Publisher>OK1MLG</Publisher>
     <StartMenuDir>QLog</StartMenuDir>

installer/packages/de.dl2ic.qlog/meta/package.xml

@@ -2,8 +2,8 @@
 <Package>
     <DisplayName>QLog</DisplayName>
     <Description>The QLog main application.</Description>
-    <Version>0.44.0-1</Version>
-    <ReleaseDate>2025-05-09</ReleaseDate>
+    <Version>0.44.1-1</Version>
+    <ReleaseDate>2025-05-11</ReleaseDate>
     <Default>true</Default>
     <Required>true</Required>
     <Script>installscript.qs</Script>

res/io.github.foldynl.QLog.metainfo.xml

@@ -51,6 +51,13 @@
   <url type="vcs-browser">https://github.com/foldynl/QLog</url>
   <url type="contribute">https://github.com/foldynl/QLog/blob/master/CONTRIBUTING.md</url>
   <releases>
+    <release version="0.44.1" date="2025-05-11">
+      <description>
+        <ul>
+          <li>Fixed Rotator Widget Seg Fault for new users (issue #666)</li>
+        </ul>
+      </description>
+    </release>
     <release version="0.44.0" date="2025-05-09">
       <description>
         <ul>

rpm_spec/qlog.spec

@@ -42,6 +42,9 @@ INSTALL_ROOT=%{buildroot} make -f Makefile install
 %{_metainfodir}/*
 
 %changelog
+* Sun May 11 2025 Ladislav Foldyna - 0.44.1-1
+- Fixed Rotator Widget Seg Fault for new users (issue #666)
+
 * Fri May 9 2025 Ladislav Foldyna - 0.44.0-1
 - [NEW] - Activity Manager - Added SKCC, UKSMG and FISTS as Dynamic Fields
 - [NEW] - QSO - FISTS, SKCC, and UKSMG are auto-filled from MembershipQE (issue #628)

ui/RotatorWidget.cpp

@@ -15,6 +15,9 @@ MODULE_IDENTIFICATION("qlog.ui.rotatorwidget");
 
 RotatorWidget::RotatorWidget(QWidget *parent) :
     QWidget(parent),
+    antennaNeedle(nullptr),
+    requestedAzimuthNeedle(nullptr),
+    QSOAzimuthNeedle(nullptr),
     waitingFirstValue(true),
     compassScene(nullptr),
     ui(new Ui::RotatorWidget),
@@ -105,8 +108,11 @@ void RotatorWidget::setRequestedAz(double requestedAz)
         return;
 
     requestedAzimuth = requestedAz;
-    requestedAzimuthNeedle->show();
-    requestedAzimuthNeedle->setRotation(requestedAz);
+    if ( requestedAzimuthNeedle )
+    {
+        requestedAzimuthNeedle->show();
+        requestedAzimuthNeedle->setRotation(requestedAz);
+    }
 }
 
 void RotatorWidget::setBearing(double in_azimuth)
@@ -129,23 +135,27 @@ void RotatorWidget::positionChanged(double in_azimuth, double in_elevation)
     qCDebug(function_parameters) << in_azimuth <<in_elevation;
 
     antennaAzimuth = (in_azimuth < 0.0 ) ? 360.0 + in_azimuth : in_azimuth;
-    antennaNeedle->setRotation(antennaAzimuth);
+    if ( antennaNeedle) antennaNeedle->setRotation(antennaAzimuth);
     if ( waitingFirstValue )
     {
         waitingFirstValue = false;
-        requestedAzimuthNeedle->setRotation(in_azimuth);
+        if ( requestedAzimuthNeedle) requestedAzimuthNeedle->setRotation(in_azimuth);
     }
     ui->gotoDoubleSpinBox->blockSignals(true);
     ui->gotoDoubleSpinBox->setValue(antennaAzimuth);
     ui->gotoDoubleSpinBox->blockSignals(false);
-    if ( qAbs(qRound(requestedAzimuth) - qRound(in_azimuth)) <= AZIMUTH_DEAD_BAND )
+    if ( qAbs(qRound(requestedAzimuth) - qRound(in_azimuth)) <= AZIMUTH_DEAD_BAND
+         && requestedAzimuthNeedle )
         requestedAzimuthNeedle->hide();
 }
 
 void RotatorWidget::setQSOBearing(double , double )
 {
     FCT_IDENTIFICATION;
 
+    if ( !QSOAzimuthNeedle )
+        return;
+
     qsoAzimuth = getQSOBearing();
 
     qCDebug(runtime) << qsoAzimuth;
@@ -492,7 +502,7 @@ void RotatorWidget::rotConnected()
     ui->userButtonsProfileCombo->setEnabled(true);
     refreshRotUserButtons();
     waitingFirstValue = true;
-    antennaNeedle->show();
+    if ( antennaNeedle ) antennaNeedle->show();
 }
 
 void RotatorWidget::rotDisconnected()
@@ -508,8 +518,8 @@ void RotatorWidget::rotDisconnected()
     ui->userButton_2->setEnabled(false);
     ui->userButton_3->setEnabled(false);
     ui->userButton_4->setEnabled(false);
-    antennaNeedle->hide();
-    requestedAzimuthNeedle->hide();
+    if ( antennaNeedle ) antennaNeedle->hide();
+    if ( requestedAzimuthNeedle) requestedAzimuthNeedle->hide();
     requestedAzimuth = qQNaN();
 }