fix: unexpected special replacement pattern (#293)

lawvs · web-flow · commit 52164007c11c · 2024-12-15T15:37:24.000+01:00
* fix: unexpected special replacement patterns

* chore: add test

* fix: other env

* chore: follow code review

* chore: tweak test

* chore: replace with literal string for performance
diff --git a/cjs/html/text-element.js b/cjs/html/text-element.js
@@ -10,7 +10,7 @@ class TextElement extends HTMLElement {
 
   toString() {
     const outerHTML = toString.call(this.cloneNode());
-    return outerHTML.replace(/></, `>${this.textContent}<`);
+    return outerHTML.replace('><', () => `>${this.textContent}<`);
   }
 }
 exports.TextElement = TextElement
diff --git a/esm/html/text-element.js b/esm/html/text-element.js
@@ -9,6 +9,6 @@ export class TextElement extends HTMLElement {
 
   toString() {
     const outerHTML = toString.call(this.cloneNode());
-    return outerHTML.replace(/></, `>${this.textContent}<`);
+    return outerHTML.replace('><', () => `>${this.textContent}<`);
   }
 }
diff --git a/test/html/script-element.js b/test/html/script-element.js
@@ -140,3 +140,17 @@ assert(head.firstChild.innerHTML, 'html`<p>ok</p>`;', '<script>.innerHTML');
   script.type = 'text/javascript';
   assert(script.type, 'text/javascript', '<script>.type');
 }
+
+{
+  // https://github.com/WebReflection/linkedom/issues/292
+  const { document } = parseHTML('<html></html>');
+  const script = document.createElement('script')
+  script.innerHTML = 'const test = "$$ $& $1"'
+  document.head.append(script)
+  assert(document.toString(), '<html><head><script>const test = "$$ $& $1"</script></head></html>')
+}
+
+{
+  const { document } = parseHTML('<html><script>const test = "$$ $& $1"</script></html>');
+  assert(document.toString(), '<html><script>const test = "$$ $& $1"</script></html>')
+}
diff --git a/worker.js b/worker.js
@@ -8567,7 +8567,7 @@ class TextElement extends HTMLElement {
 
   toString() {
     const outerHTML = toString.call(this.cloneNode());
-    return outerHTML.replace(/></, `>${this.textContent}<`);
+    return outerHTML.replace('><', () => `>${this.textContent}<`);
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ class TextElement extends HTMLElement {`
`10`	`10`
`11`	`11`	`toString() {`
`12`	`12`	`const outerHTML = toString.call(this.cloneNode());`
`13`		- return outerHTML.replace(/></, `>${this.textContent}<`);
	`13`	+ return outerHTML.replace('><', () => `>${this.textContent}<`);
`14`	`14`	`}`
`15`	`15`	`}`
`16`	`16`	`exports.TextElement = TextElement`
Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,6 @@ export class TextElement extends HTMLElement {`
`9`	`9`
`10`	`10`	`toString() {`
`11`	`11`	`const outerHTML = toString.call(this.cloneNode());`
`12`		- return outerHTML.replace(/></, `>${this.textContent}<`);
	`12`	+ return outerHTML.replace('><', () => `>${this.textContent}<`);
`13`	`13`	`}`
`14`	`14`	`}`
Original file line number	Diff line number	Diff line change
`@@ -8567,7 +8567,7 @@ class TextElement extends HTMLElement {`
`8567`	`8567`
`8568`	`8568`	`toString() {`
`8569`	`8569`	`const outerHTML = toString.call(this.cloneNode());`
`8570`		- return outerHTML.replace(/></, `>${this.textContent}<`);
	`8570`	+ return outerHTML.replace('><', () => `>${this.textContent}<`);
`8571`	`8571`	`}`
`8572`	`8572`	`}`
`8573`	`8573`