feat: JSON output #2
Conversation
src/main/java/us/warframestat/moddetection/api/detection/DetectModInfo.java
Outdated
Show resolved
Hide resolved
src/main/java/us/warframestat/moddetection/api/detection/DetectMods.java
Outdated
Show resolved
Hide resolved
|
I'll do those things, and I'll also add that you can specify the data directory where everything already is, so that the entire process is faster and doesn't take up a lot of space |
|
could you add the ci and verifications so we can check all of that stuff? |
TobiTenno
left a comment
TobiTenno
left a comment
There was a problem hiding this comment.
lookin for some base level ci so we can verify change to change
src/main/java/us/warframestat/moddetection/api/utils/WarframeMarketAPI.java
Show resolved
Hide resolved
|
Sorry, was busy the past two weeks, I'll fix some issues later today |
|
i'm good with it, but i'll let @Bourne-ID have final approval since i made some changes |
|
Will take a look once I’m back home, about 45 minutes.
…On Sat, Feb 12, 2022 at 2:15 PM Matt Voboril ***@***.***> wrote:
i'm good with it, but i'll let @Bourne-ID <https://github.com/Bourne-ID>
have final approval since i made some changes
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABV66UDUN4OUOCFKIUTPFWTU22WUJANCNFSM5LZX5UMQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Apologies, looking at this now. |
Bourne-ID
left a comment
Bourne-ID
left a comment
There was a problem hiding this comment.
Couple of minor comments but non-blockers on merge.
src/main/java/us/warframestat/moddetection/api/detection/DetectModInfo.java
Show resolved
Hide resolved
|
I'm working on refactoring some of the problems I have in my above, mostly making tests run, cause i realized my part didn't actually make tests run, and getting API executable from cli, since that's the idea of having json output |
|
ok, so looks like i'm missing some linkage for it to work all the way |
TobiTenno
force-pushed
the
json_changes
branch
from
b70cd4e to
8f5243f
Compare
|
@Bourne-ID @Tiebe what do y'all think of the changes? |
Sorry for the late reply, but looks good to me! |
# [1.1.0](v1.0.0...v1.1.0) (2022-03-27) ### Features * JSON output ([#2](#2)) ([b775c4b](b775c4b))
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
What did you fix? (provide a description or issue closes statement)
Add json output