Skip to content

Commit 4f24299

Browse files
committed
Remove the ability to have no timeout for waiting for a target - it is a bad practice
1 parent e3dbb41 commit 4f24299

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

src/vws/vws.py

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,7 @@ def wait_for_target_processed(
334334
self,
335335
target_id: str,
336336
seconds_between_requests: float = 0.2,
337-
timeout_seconds: float | None = 60 * 5,
337+
timeout_seconds: float = 60 * 5,
338338
) -> None:
339339
"""
340340
Wait up to five minutes (arbitrary) for a target to get past the
@@ -348,8 +348,7 @@ def wait_for_target_processed(
348348
decrease the number of calls made to the API, to decrease the
349349
likelihood of hitting the request quota.
350350
timeout_seconds: The maximum number of seconds to wait for the
351-
target to be processed. If ``None`` is given, no maximum is
352-
applied.
351+
target to be processed.
353352
354353
Raises:
355354
~vws.exceptions.vws_exceptions.AuthenticationFailure: The secret
@@ -371,10 +370,9 @@ def wait_for_target_processed(
371370
if report.status != TargetStatuses.PROCESSING:
372371
return
373372

374-
if timeout_seconds is not None:
375-
elapsed_time = time.monotonic() - start_time
376-
if elapsed_time > timeout_seconds: # pragma: no cover
377-
raise TargetProcessingTimeout
373+
elapsed_time = time.monotonic() - start_time
374+
if elapsed_time > timeout_seconds: # pragma: no cover
375+
raise TargetProcessingTimeout
378376

379377
time.sleep(seconds_between_requests)
380378

0 commit comments

Comments
 (0)