From bf04e53559fe3cde94800e7eb6d566ad3ff7c135 Mon Sep 17 00:00:00 2001 From: d2n0s4ur Date: Tue, 27 Aug 2024 14:38:20 +0900 Subject: [PATCH 1/2] fix: add checking keydown isComposing for prevent create blocks when press enter. --- .../hooks/useGridSuggestionMenuKeyboardNavigation.ts | 2 +- .../SuggestionMenu/hooks/useSuggestionMenuKeyboardNavigation.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react/src/components/SuggestionMenu/GridSuggestionMenu/hooks/useGridSuggestionMenuKeyboardNavigation.ts b/packages/react/src/components/SuggestionMenu/GridSuggestionMenu/hooks/useGridSuggestionMenuKeyboardNavigation.ts index 739dbdec7e..b3f30fb119 100644 --- a/packages/react/src/components/SuggestionMenu/GridSuggestionMenu/hooks/useGridSuggestionMenuKeyboardNavigation.ts +++ b/packages/react/src/components/SuggestionMenu/GridSuggestionMenu/hooks/useGridSuggestionMenuKeyboardNavigation.ts @@ -55,7 +55,7 @@ export function useGridSuggestionMenuKeyboardNavigation( if (event.key === "Enter") { event.preventDefault(); - if (items.length) { + if (items.length && !event.isComposing) { onItemClick?.(items[selectedIndex]); } diff --git a/packages/react/src/components/SuggestionMenu/hooks/useSuggestionMenuKeyboardNavigation.ts b/packages/react/src/components/SuggestionMenu/hooks/useSuggestionMenuKeyboardNavigation.ts index f618c8f309..84c46a01af 100644 --- a/packages/react/src/components/SuggestionMenu/hooks/useSuggestionMenuKeyboardNavigation.ts +++ b/packages/react/src/components/SuggestionMenu/hooks/useSuggestionMenuKeyboardNavigation.ts @@ -33,7 +33,7 @@ export function useSuggestionMenuKeyboardNavigation( return true; } - if (event.key === "Enter") { + if (event.key === "Enter" && !event.isComposing) { event.preventDefault(); if (items.length) { From 0a7f964422a1dbe910c05979880670c973ae7bd1 Mon Sep 17 00:00:00 2001 From: d2n0s4ur Date: Tue, 27 Aug 2024 14:55:41 +0900 Subject: [PATCH 2/2] chore: move isCompoing to key check --- .../hooks/useGridSuggestionMenuKeyboardNavigation.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react/src/components/SuggestionMenu/GridSuggestionMenu/hooks/useGridSuggestionMenuKeyboardNavigation.ts b/packages/react/src/components/SuggestionMenu/GridSuggestionMenu/hooks/useGridSuggestionMenuKeyboardNavigation.ts index b3f30fb119..a0b125bbc2 100644 --- a/packages/react/src/components/SuggestionMenu/GridSuggestionMenu/hooks/useGridSuggestionMenuKeyboardNavigation.ts +++ b/packages/react/src/components/SuggestionMenu/GridSuggestionMenu/hooks/useGridSuggestionMenuKeyboardNavigation.ts @@ -52,10 +52,10 @@ export function useGridSuggestionMenuKeyboardNavigation( return true; } - if (event.key === "Enter") { + if (event.key === "Enter" && !event.isComposing) { event.preventDefault(); - if (items.length && !event.isComposing) { + if (items.length) { onItemClick?.(items[selectedIndex]); }