Skip to content

Emoji item in slash menu does nothing #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task
danielrearden opened this issue Jul 24, 2024 · 4 comments
Closed
1 task

Emoji item in slash menu does nothing #963

danielrearden opened this issue Jul 24, 2024 · 4 comments
Assignees
Labels
bug Something isn't working prio:high High priority sponsor

Comments

@danielrearden
Copy link

Describe the bug
Nothing happens when clicking the emoji item in the slash menu. That's because when calling editor.openSelectionMenu, we still consider the minQueryLength passed to GridSuggestionMenuController. Setting this value to 0 makes calling editor.openSelectionMenu behave as expected, but is not desirable because now the minQueryLength is not enforced when you type :.

To Reproduce

Misc

  • Node version: 22.4.1
  • Package manager: pnpm
  • Browser: Chrome
  • I'm a sponsor and would appreciate if you could look into this sooner than later 💖
@danielrearden danielrearden added the bug Something isn't working label Jul 24, 2024
@ats1999
Copy link

ats1999 commented Jul 25, 2024

Same, emojies aren’t working

@danielrearden
Copy link
Author

FWIW, Notion does not actually open the suggestions menu for this action. Instead, it just inserts a :, which seems like a cleaner experience anyway.

@danlupascu
Copy link

Hey, any updates on this? Do you guys need help?

@matthewlipski
Copy link
Collaborator

Currently WIP in #984, looks close to being done so likely to be fixed in next release👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prio:high High priority sponsor
Projects
None yet
Development

No branches or pull requests

5 participants