Skip to content

Ability to add custom editorProps in _tiptapOptions #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
man-shar opened this issue Oct 23, 2023 · 1 comment · Fixed by #398
Closed

Ability to add custom editorProps in _tiptapOptions #389

man-shar opened this issue Oct 23, 2023 · 1 comment · Fixed by #398
Labels
enhancement New feature or request prio:high High priority

Comments

@man-shar
Copy link

man-shar commented Oct 23, 2023 •
edited
Loading

Currently the editorProps get overwritten in BlockNoteEditor.

Perhaps I'm overlooking something, but should be a tiny fix of adding ...newOptions.editorProps within that object?

Currently used a hack editor.prosemirrorView._props.handleDrop = ...

Thank you!
@man-shar man-shar added the enhancement New feature or request label Oct 23, 2023
@matthewlipski
Copy link
Collaborator

Good point! Though since this is directly accessing the TipTap API, you'll probably instead pass them to _tiptapOptions.editorProps

@matthewlipski matthewlipski added the prio:high High priority label Oct 26, 2023
@matthewlipski matthewlipski mentioned this issue Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request prio:high High priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: _tiptapOptions typing and fields getting overridden TypeCellOS/BlockNote
2 participants
@man-shar @matthewlipski