Skip to content

onEditorContentChange is not being called when updating alert type in Alert block example ( custom blocks ) #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GiladVyzer opened this issue Oct 13, 2023 · 1 comment · Fixed by #379
Labels
bug Something isn't working prio:high High priority

Comments

@GiladVyzer
Copy link

Describe the bug
After adding onEditorContentChange functionality to the Alert Block example (https://www.blocknotejs.org/examples/alert-block),
the function is not being called when changing the alert type.

Additionally, after editing the inline content that triggers the 'onEditorContentChange' function, the block props have wrong type.

image

To Reproduce

  1. Visit https://codesandbox.io/s/hardcore-meitner-cvh3kl
  2. Change the type of the alert.

Misc

  • Package manager: npm
  • Browser: Chrome
@GiladVyzer GiladVyzer added the bug Something isn't working label Oct 13, 2023
@matthewlipski
Copy link
Collaborator

Thanks! This is fortunately just a bug in the Alert block's component rather than an internal BlockNote issue. PR with the fix is up and will be merged soon👍

@matthewlipski matthewlipski added the prio:high High priority label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prio:high High priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants