Skip to content

Image Support #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
d4mr opened this issue Mar 18, 2023 · 4 comments
Closed

Image Support #145

d4mr opened this issue Mar 18, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request prio:high High priority

Comments

@d4mr
Copy link

d4mr commented Mar 18, 2023

Does BlockNote have img capabilities yet? If not, does it have plugin/custom block development capabilities that would allow for adding img capabilities without forking?

PS: Incredible work on the project! I would love to contribute for adding image support, custom block support, or otherwise. Would greatly appreciate it if you could let me know where can I get started.

@Axibord
Copy link

Axibord commented Mar 18, 2023

I want to do the same thing, I was developing a similar library for my SaaS, then I discovered this 😲

@YousefED
Copy link
Collaborator

YousefED commented Mar 20, 2023

At this moment, we don't have Image support yet. I think we should include this soon :)

For UX, I think we should aim for a Notion-like UX where:

  • images can be resized
  • an (optional) caption can be added
  • Options to align the image
  • We can drag / drop images into documents

Nice to have:

  • make it easy to include images from apis such as Giphy / Unsplash

The Atlaskit Prosemirror image element comes pretty close. See: https://atlaskit.atlassian.com/packages/editor/editor-core/example/kitchen-sink

The prosemirror element also supports text wrapping, but I doubt that works well (or is desirable) with our block-based design. Notion solves this by making it possible to have column-based block layouts - I think that should be our long-term solution.

Any other requirements you can think of?

Contributions would be very welcome! It's a relatively complicated element though, but if you have experience with Prosemirror it should be doable

@YousefED YousefED changed the title Image Support? Image Support May 30, 2023
@YousefED YousefED added the enhancement New feature or request label May 30, 2023
@horacioh
Copy link
Contributor

here's another example I found for an image component: https://gitlab.com/emergence-engineering/prosemirror-image-plugin

it has all the features you listed there @YousefED, I might try to hack it into BlockNote :)

@matthewlipski matthewlipski added the prio:low Low priority label Jul 6, 2023
@matthewlipski matthewlipski added prio:high High priority and removed prio:low Low priority labels Aug 14, 2023
@YousefED
Copy link
Collaborator

YousefED commented Dec 4, 2023

fixed by #163

@YousefED YousefED closed this as completed Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request prio:high High priority
Projects
None yet
Development

No branches or pull requests

5 participants