-
-
Notifications
You must be signed in to change notification settings - Fork 558
Image Support #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I want to do the same thing, I was developing a similar library for my SaaS, then I discovered this 😲 |
At this moment, we don't have Image support yet. I think we should include this soon :) For UX, I think we should aim for a Notion-like UX where:
Nice to have:
The Atlaskit Prosemirror image element comes pretty close. See: https://atlaskit.atlassian.com/packages/editor/editor-core/example/kitchen-sink The prosemirror element also supports text wrapping, but I doubt that works well (or is desirable) with our block-based design. Notion solves this by making it possible to have column-based block layouts - I think that should be our long-term solution. Any other requirements you can think of? Contributions would be very welcome! It's a relatively complicated element though, but if you have experience with Prosemirror it should be doable |
here's another example I found for an image component: https://gitlab.com/emergence-engineering/prosemirror-image-plugin it has all the features you listed there @YousefED, I might try to hack it into BlockNote :) |
fixed by #163 |
Does BlockNote have img capabilities yet? If not, does it have plugin/custom block development capabilities that would allow for adding img capabilities without forking?
PS: Incredible work on the project! I would love to contribute for adding image support, custom block support, or otherwise. Would greatly appreciate it if you could let me know where can I get started.
The text was updated successfully, but these errors were encountered: