Commit ceb1a51
### **User description**
TT-13130 updated version of gorpc library and prevent panic on start
edge (#6629)
### **User description**
<details open>
<summary><a href="https://tyktech.atlassian.net/browse/TT-13130"
title="TT-13130" target="_blank">TT-13130</a></summary>
<br />
<table>
<tr>
<th>Summary</th>
<td>Tyk Cloud: Panic appears when a user tried to deploy GW before
Control Plane is in deployed state </td>
</tr>
<tr>
<th>Type</th>
<td>
<img alt="Bug"
src="https://tyktech.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10303?size=medium"
/>
Bug
</td>
</tr>
<tr>
<th>Status</th>
<td>In Dev</td>
</tr>
<tr>
<th>Points</th>
<td>N/A</td>
</tr>
<tr>
<th>Labels</th>
<td><a
href="https://tyktech.atlassian.net/issues?jql=project%20%3D%20TT%20AND%20labels%20%3D%20Re_open%20ORDER%20BY%20created%20DESC"
title="Re_open">Re_open</a></td>
</tr>
</table>
</details>
<!--
do not remove this marker as it will break jira-lint's functionality.
added_by_jira_lint
-->
---
<!-- Provide a general summary of your changes in the Title above -->
## Description
Moved the logic of waitgroup to be handled internally in the gorpc
library. GW only have to wait until done()
## Related Issue
TT-13130
## Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
## How This Has Been Tested
<!-- Please describe in detail how you tested your changes -->
<!-- Include details of your testing environment, and the tests -->
<!-- you ran to see how your change affects other areas of the code,
etc. -->
<!-- This information is helpful for reviewers and QA. -->
## Screenshots (if appropriate)
## Types of changes
<!-- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Refactoring or add test (improvements in base code or adds test
coverage to functionality)
## Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply -->
<!-- If there are no documentation updates required, mark the item as
checked. -->
<!-- Raise up any additional concerns not covered by the checklist. -->
- [ ] I ensured that the documentation is up to date
- [ ] I explained why this PR updates go.mod in detail with reasoning
why it's required
- [ ] I would like a code coverage CI quality gate exception and have
explained why
___
### **PR Type**
Bug fix, Enhancement
___
### **Description**
- Refactored the connection dialing logic in `rpc_client.go` to remove
manual `sync.WaitGroup` handling, leveraging the internal wait group
management provided by the `gorpc` library.
- Updated the `gorpc` library to a newer version in `go.mod` and
`go.sum`, ensuring compatibility and leveraging improvements.
___
### **Changes walkthrough** 📝
<table><thead><tr><th></th><th align="left">Relevant
files</th></tr></thead><tbody><tr><td><strong>Enhancement</strong></td><td><table>
<tr>
<td>
<details>
<summary><strong>rpc_client.go</strong><dd><code>Refactor connection
dialing wait group handling</code>
</dd></summary>
<hr>
rpc/rpc_client.go
<li>Removed manual handling of <code>sync.WaitGroup</code> for
connection dialing.<br> <li> Utilized
<code>clientSingleton.ConnectionDialingWG</code> for managing connection
<br>readiness.<br>
</details>
</td>
<td><a
href="https://github.com/TykTechnologies/tyk/pull/6629/files#diff-3b88914c99bb9418e44e6389ce73579843562e8900730b380d7fff2e95c51033">+1/-7</a>
</td>
</tr>
</table></td></tr><tr><td><strong>Dependencies</strong></td><td><table>
<tr>
<td>
<details>
<summary><strong>go.mod</strong><dd><code>Update gorpc library version
in go.mod</code>
</dd></summary>
<hr>
go.mod
- Updated `gorpc` library version to latest.
</details>
</td>
<td><a
href="https://github.com/TykTechnologies/tyk/pull/6629/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6">+1/-1</a>
</td>
</tr>
<tr>
<td>
<details>
<summary><strong>go.sum</strong><dd><code>Update go.sum for new gorpc
version</code>
</dd></summary>
<hr>
go.sum
- Updated checksums for new `gorpc` library version.
</details>
</td>
<td><a
href="https://github.com/TykTechnologies/tyk/pull/6629/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63">+8/-2</a>
</td>
</tr>
</table></td></tr></tr></tbody></table>
___
> 💡 **PR-Agent usage**: Comment `/help "your question"` on any pull
request to receive relevant information
---------
Co-authored-by: sredny buitrago <[email protected]>
___
### **PR Type**
Bug fix, Enhancement
___
### **Description**
- Refactored the connection dialing logic in `rpc_client.go` to remove
manual `sync.WaitGroup` handling, leveraging the internal wait group
management provided by the `gorpc` library.
- Updated the `gorpc` library to a newer version in `go.mod` and
`go.sum`, ensuring compatibility and leveraging improvements.
___
### **Changes walkthrough** 📝
<table><thead><tr><th></th><th align="left">Relevant
files</th></tr></thead><tbody><tr><td><strong>Enhancement</strong></td><td><table>
<tr>
<td>
<details>
<summary><strong>rpc_client.go</strong><dd><code>Refactor connection
dialing wait group handling</code>
</dd></summary>
<hr>
rpc/rpc_client.go
<li>Removed manual handling of <code>sync.WaitGroup</code> for
connection dialing.<br> <li> Utilized
<code>clientSingleton.ConnectionDialingWG</code> for managing connection
<br>readiness.<br>
</details>
</td>
<td><a
href="https://github.com/TykTechnologies/tyk/pull/6638/files#diff-3b88914c99bb9418e44e6389ce73579843562e8900730b380d7fff2e95c51033">+1/-8</a>
</td>
</tr>
</table></td></tr><tr><td><strong>Dependencies</strong></td><td><table>
<tr>
<td>
<details>
<summary><strong>go.mod</strong><dd><code>Update gorpc library version
in go.mod</code>
</dd></summary>
<hr>
go.mod
- Updated `gorpc` library version to the latest.
</details>
</td>
<td><a
href="https://github.com/TykTechnologies/tyk/pull/6638/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6">+1/-1</a>
</td>
</tr>
<tr>
<td>
<details>
<summary><strong>go.sum</strong><dd><code>Update go.sum for new gorpc
version</code>
</dd></summary>
<hr>
go.sum
- Updated checksums for new `gorpc` library version.
</details>
</td>
<td><a
href="https://github.com/TykTechnologies/tyk/pull/6638/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63">+2/-2</a>
</td>
</tr>
</table></td></tr></tr></tbody></table>
___
> 💡 **PR-Agent usage**: Comment `/help "your question"` on any pull
request to receive relevant information
---------
Co-authored-by: Sredny M <[email protected]>
Co-authored-by: sredny buitrago <[email protected]>
1 parent 0540949 commit ceb1a51
3 files changed
+4
-11
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
49 | | - | |
| 48 | + | |
| 49 | + | |
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
258 | 258 | | |
259 | 259 | | |
260 | 260 | | |
261 | | - | |
262 | | - | |
263 | | - | |
264 | | - | |
265 | 261 | | |
266 | 262 | | |
267 | 263 | | |
| |||
298 | 294 | | |
299 | 295 | | |
300 | 296 | | |
301 | | - | |
302 | | - | |
303 | 297 | | |
304 | 298 | | |
305 | 299 | | |
| |||
311 | 305 | | |
312 | 306 | | |
313 | 307 | | |
314 | | - | |
315 | 308 | | |
316 | | - | |
| 309 | + | |
317 | 310 | | |
318 | 311 | | |
319 | 312 | | |
| |||
0 commit comments