Merge pull request #88 from trufae/parse-hard

Be more strict when parsing plists

Author: mreinstein

.github/workflows/ci.yml

@@ -2,6 +2,7 @@ name: ci
 
 on:
   push:
+  pull_request:
 
 jobs:
   build:

lib/parse.js

@@ -220,5 +220,7 @@ function parsePlistXML (node) {
 
   } else if (node.nodeName === 'false') {
     return false;
+  } else {
+    throw new Error('Invalid PLIST tag ' + node.nodeName);
   }
 }

test/parse.js

@@ -519,4 +519,30 @@ int main(int argc, char *argv[])
       });
     });
   });
+  describe('invalid formats', function () {
+    it('should fail parsing invalid xml plist', function () {
+      var xml = multiline(function () {
+/*
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+  <key>test</key>
+  <strong>Testing</strong>
+  <key>bar</key>
+  <string></string>
+</dict>
+</plist>
+*/
+      });
+      assert.throws(function () {
+        var parsed = parse(xml);
+      });
+    });
+    it('ensure empty strings arent valid plist', function () {
+      assert.throws(function () {
+        var parsed = parse('');
+      });
+    });
+  });
 });