feat: bump nitro modules version (#4641)

Author: KrzysztofMoch

README.md

@@ -51,11 +51,11 @@ The most battle-tested open-source video player component for React Native with
 ### Requirements
 
 - React Native 0.75 or higher
-- `react-native-nitro-modules` (>=0.24.0) - Please see [nitro requirements](https://nitro.margelo.com/docs/minimum-requirements)
+- `react-native-nitro-modules` (>=0.27.2) - Please see [nitro requirements](https://nitro.margelo.com/docs/minimum-requirements)
 
 ### Install
 
-`react-native-video` requires `react-native-nitro-modules` (>=0.24.0) in your project.
+`react-native-video` requires `react-native-nitro-modules` (>=0.27.2) in your project.
 ```bash
 npm install react-native-nitro-modules
 ```
@@ -78,34 +78,7 @@ You can apply it using `patch-package`.
 
 Without this patch you won't be able "recognize" errors, all will be thrown as unknown errors.
 
-```diff
-diff --git a/node_modules/react-native-nitro-modules/cpp/core/HybridFunction.hpp b/node_modules/react-native-nitro-modules/cpp/core/HybridFunction.hpp
-index aefd987..c2e06fb 100644
---- a/node_modules/react-native-nitro-modules/cpp/core/HybridFunction.hpp
-+++ b/node_modules/react-native-nitro-modules/cpp/core/HybridFunction.hpp
-@@ -23,6 +23,10 @@ struct JSIConverter;
- #include <string>
- #include <type_traits>
- 
-+#ifdef ANDROID
-+#include <fbjni/fbjni.h>
-+#endif
-+
- namespace margelo::nitro {
- 
- using namespace facebook;
-@@ -118,6 +122,10 @@ public:
-         std::string funcName = getHybridFuncFullName<THybrid>(kind, name, hybridInstance.get());
-         std::string message = exception.what();
-         throw jsi::JSError(runtime, funcName + ": " + message);
-+      } catch (const jni::JniException& exception) {
-+        std::string funcName = getHybridFuncFullName<THybrid>(kind, name, hybridInstance.get());
-+        std::string message = exception.what();
-+        throw jsi::JSError(runtime, funcName + ": " + message);
- #pragma clang diagnostic pop
- #endif
-       } catch (...) {
-```
+see [installation guide](https://docs.thewidlarzgroup.com/react-native-video/docs/v7/installation#patch-for-react-native--080)
 </details>
 
 ### Usage

bun.lock

@@ -56,7 +56,7 @@
         "@react-native-community/slider": "^4.5.6",
         "react": "18.3.1",
         "react-native": "^0.77.0",
-        "react-native-nitro-modules": "^0.26.0",
+        "react-native-nitro-modules": "^0.27.0",
         "react-native-video": "*",
       },
       "devDependencies": {
@@ -89,18 +89,18 @@
         "eslint": "^8.51.0",
         "eslint-config-prettier": "^9.0.0",
         "eslint-plugin-prettier": "^5.0.1",
-        "nitro-codegen": ">=0.26.0",
+        "nitro-codegen": "^0.27.0",
         "prettier": "^3.0.3",
         "react": "18.3.1",
         "react-native": "^0.77.0",
         "react-native-builder-bob": "^0.40.0",
-        "react-native-nitro-modules": ">=0.26.0",
+        "react-native-nitro-modules": "^0.27.0",
         "typescript": "^5.2.2",
       },
       "peerDependencies": {
         "react": "*",
         "react-native": "*",
-        "react-native-nitro-modules": ">=0.25.0",
+        "react-native-nitro-modules": ">=0.27.2",
       },
     },
   },
@@ -2597,7 +2597,7 @@
 
     "new-github-release-url": ["[email protected]", "", { "dependencies": { "type-fest": "^2.5.1" } }, "sha512-NHDDGYudnvRutt/VhKFlX26IotXe1w0cmkDm6JGquh5bz/bDTw0LufSmH/GxTjEdpHEO+bVKFTwdrcGa/9XlKQ=="],
 
-    "nitro-codegen": ["nitro-codegen@0.26.2", "", { "dependencies": { "chalk": "^5.3.0", "react-native-nitro-modules": "^0.26.2", "ts-morph": "^25.0.0", "yargs": "^17.7.2", "zod": "^3.23.8" }, "bin": { "nitro-codegen": "lib/index.js" } }, "sha512-Z66PE0kzwrTdvyUMsq0eCv6IcEsv+tpkZovGcIat/UVJrcbbBNaScKuFRL07Qoh7idm4mErJiei6IRewJUDghA=="],
+    "nitro-codegen": ["nitro-codegen@0.27.2", "", { "dependencies": { "chalk": "^5.3.0", "react-native-nitro-modules": "^0.27.2", "ts-morph": "^25.0.0", "yargs": "^17.7.2", "zod": "^4.0.5" }, "bin": { "nitro-codegen": "lib/index.js" } }, "sha512-8s47CFGu2QYvqbKacmtpowgcj577fX60pxFiIDHyM0scT8u28thwAmy6ByskCySHiLFDO7OX6yVT+TrJHc6rQQ=="],
 
     "no-case": ["[email protected]", "", { "dependencies": { "lower-case": "^2.0.2", "tslib": "^2.0.3" } }, "sha512-fgAN3jGAh+RoxUGZHTSOLJIqUc2wmoBwGR4tbpNAKmmovFoWq0OdRkb0VkldReO2a2iBT/OEulG9XSUc10r3zg=="],
 
@@ -2977,7 +2977,7 @@
 
     "react-native-monorepo-config": ["[email protected]", "", { "dependencies": { "escape-string-regexp": "^5.0.0", "fast-glob": "^3.3.3" } }, "sha512-GLFYMEEcbltxZw7oUbbh/p0oXqA52lSirXt7o/N1qD6CFTvku84OVL6teeQ1Ef92pq+bepq4x0Qz+d6lapVbuQ=="],
 
-    "react-native-nitro-modules": ["react-native-nitro-modules@0.26.2", "", { "peerDependencies": { "react": "*", "react-native": "*" } }, "sha512-PvTUOryU/J1RDsPh1IvmAEDkYVVL32wCIYxkg6HsKgq+Dl+C8lth/MtW7cRZ+fJ0qW21NILbhBdhSXFzBx51fA=="],
+    "react-native-nitro-modules": ["react-native-nitro-modules@0.27.2", "", { "peerDependencies": { "react": "*", "react-native": "*" } }, "sha512-wHUs6m4e1MkhV7oPMNSZwCZcoaepLNfPScc+Pm9pwgtv26sTADXnu66MzyodSl6kO6TcTC1Pf+5VyQMgesx08w=="],
 
     "react-native-video": ["react-native-video@workspace:packages/react-native-video"],
 
@@ -3579,7 +3579,7 @@
 
     "yoctocolors-cjs": ["[email protected]", "", {}, "sha512-cYVsTjKl8b+FrnidjibDWskAv7UKOfcwaVZdp/it9n1s9fU3IkgDbhdIRKCW4JDsAlECJY0ytoVPT3sK6kideA=="],
 
-    "zod": ["zod@3.24.2", "", {}, "sha512-lY7CDW43ECgW9u1TcT3IoXHflywfVqDYze4waEz812jR/bZ8FHDsl7pFQoSZTz5N+2NqRXs8GBwnAwo3ZNxqhQ=="],
+    "zod": ["zod@4.0.14", "", {}, "sha512-nGFJTnJN6cM2v9kXL+SOBq3AtjQby3Mv5ySGFof5UGRHrRioSJ5iG680cYNjE/yWk671nROcpPj4hAS8nyLhSw=="],
 
     "zwitch": ["[email protected]", "", {}, "sha512-V50KMwwzqJV0NpZIZFwfOD5/lyny3WlSzRiXgA0G7VUnRlqttta1L6UQIHzd6EuBY/cHGfwTIck7w1yH6Q5zUw=="],
 

docs/docs/installation.md

@@ -14,7 +14,7 @@ React Native Video is a library that allows you to play various kind of videos i
 
 ### Minimal Package Requirements
 - `react-native` `0.75.0` or higher
-- `react-native-nitro-modules` `0.26.0` or higher 
+- `react-native-nitro-modules` `0.27.2` or higher 
 
 ## Installation
 
@@ -51,6 +51,57 @@ npx react-native run-ios # run on iOS
 npx react-native run-android # run on Android
 ```
 
+## Patch for react-native < 0.80
+
+`react-native` < 0.80 have bug that prevents to properly handle errors by nitro modules on Android.
+We highly recommend to apply bellow patch for `react-native-nitro-modules` to fix this issue.
+You can apply it using `patch-package`.
+
+:::warning
+Without this patch you won't be able "recognize" errors, all will be thrown as unknown errors.
+:::
+
+<details>
+  <summary>For `react-native-nitro-modules` 0.27.X or higher</summary>
+
+  ```diff
+  diff --git a/node_modules/react-native-nitro-modules/cpp/core/HybridFunction.hpp b/node_modules/react-native-nitro-modules/cpp/core/HybridFunction.hpp
+  index efcea05..ffad3f2 100644
+  --- a/node_modules/react-native-nitro-modules/cpp/core/HybridFunction.hpp
+  +++ b/node_modules/react-native-nitro-modules/cpp/core/HybridFunction.hpp
+  @@ -23,6 +23,10 @@ struct JSIConverter;
+  #include <string>
+  #include <type_traits>
+
+  +#ifdef ANDROID
+  +#include <fbjni/fbjni.h>
+  +#endif
+  +
+  namespace margelo::nitro {
+
+  using namespace facebook;
+  @@ -109,6 +113,15 @@ public:
+          std::string funcName = getHybridFuncFullName<THybrid>(kind, name, hybridInstance.get());
+          std::string message = exception.what();
+          throw jsi::JSError(runtime, funcName + ": " + message);
+  +#ifdef ANDROID
+  +#pragma clang diagnostic push
+  +#pragma clang diagnostic ignored "-Wexceptions"
+  +      } catch (const jni::JniException& exception) {
+  +        std::string funcName = getHybridFuncFullName<THybrid>(kind, name, hybridInstance.get());
+  +        std::string message = exception.what();
+  +        throw jsi::JSError(runtime, funcName + ": " + message);
+  +#pragma clang diagnostic pop
+  +#endif
+        } catch (...) {
+          // Some unknown exception was thrown - add method name information and re-throw as `JSError`.
+          std::string funcName = getHybridFuncFullName<THybrid>(kind, name, hybridInstance.get());
+  ```
+
+  see [raw](https://github.com/TheWidlarzGroup/react-native-video/blob/v7/example/patches/react-native-nitro-modules%2B0.27.2.patch)
+</details>
+
+
 ## Usage
 
 ```tsx title="App.tsx"

example/ios/Podfile.lock

@@ -8,7 +8,7 @@ PODS:
   - hermes-engine (0.77.2):
     - hermes-engine/Pre-built (= 0.77.2)
   - hermes-engine/Pre-built (0.77.2)
-  - NitroModules (0.26.2):
+  - NitroModules (0.27.2):
     - DoubleConversion
     - glog
     - hermes-engine
@@ -1816,7 +1816,7 @@ SPEC CHECKSUMS:
   fmt: a40bb5bd0294ea969aaaba240a927bd33d878cdd
   glog: eb93e2f488219332457c3c4eafd2738ddc7e80b8
   hermes-engine: 8eb265241fa1d7095d3a40d51fd90f7dce68217c
-  NitroModules: 39248e88212416d858a4f4561cf719c6cc8ef900
+  NitroModules: 7ed5fd8f6f1e814810b9df26830b78f3355690bf
   RCT-Folly: e78785aa9ba2ed998ea4151e314036f6c49e6d82
   RCTDeprecation: 85b72250b63cfb54f29ca96ceb108cb9ef3c2079
   RCTRequired: 567cb8f5d42b990331bfd93faad1d8999b1c1736

example/package.json

@@ -13,7 +13,7 @@
     "@react-native-community/slider": "^4.5.6",
     "react": "18.3.1",
     "react-native": "^0.77.0",
-    "react-native-nitro-modules": "^0.26.0",
+    "react-native-nitro-modules": "^0.27.0",
     "react-native-video": "*"
   },
   "devDependencies": {

example/patches/react-native-nitro-modules+0.26.2.patch renamed to example/patches/react-native-nitro-modules+0.26.2.patch.old

@@ -0,0 +1,31 @@
+diff --git a/node_modules/react-native-nitro-modules/cpp/core/HybridFunction.hpp b/node_modules/react-native-nitro-modules/cpp/core/HybridFunction.hpp
+index efcea05..ffad3f2 100644
+--- a/node_modules/react-native-nitro-modules/cpp/core/HybridFunction.hpp
++++ b/node_modules/react-native-nitro-modules/cpp/core/HybridFunction.hpp
+@@ -23,6 +23,10 @@ struct JSIConverter;
+ #include <string>
+ #include <type_traits>
+ 
++#ifdef ANDROID
++#include <fbjni/fbjni.h>
++#endif
++
+ namespace margelo::nitro {
+ 
+ using namespace facebook;
+@@ -109,6 +113,15 @@ public:
+         std::string funcName = getHybridFuncFullName<THybrid>(kind, name, hybridInstance.get());
+         std::string message = exception.what();
+         throw jsi::JSError(runtime, funcName + ": " + message);
++#ifdef ANDROID
++#pragma clang diagnostic push
++#pragma clang diagnostic ignored "-Wexceptions"
++      } catch (const jni::JniException& exception) {
++        std::string funcName = getHybridFuncFullName<THybrid>(kind, name, hybridInstance.get());
++        std::string message = exception.what();
++        throw jsi::JSError(runtime, funcName + ": " + message);
++#pragma clang diagnostic pop
++#endif
+       } catch (...) {
+         // Some unknown exception was thrown - add method name information and re-throw as `JSError`.
+         std::string funcName = getHybridFuncFullName<THybrid>(kind, name, hybridInstance.get());

example/patches/react-native-nitro-modules+0.27.2.patch

@@ -338,10 +338,6 @@ class HybridVideoPlayer() : HybridVideoPlayerSpec() {
     }
   }
 
-  override fun clean() {
-    release()
-  }
-
   fun movePlayerToVideoView(videoView: VideoView) {
     VideoManager.addViewToPlayer(videoView, this)
 
@@ -351,6 +347,10 @@ class HybridVideoPlayer() : HybridVideoPlayerSpec() {
     }
   }
 
+  override fun dispose() {
+    release()
+  }
+
   override val memorySize: Long
     get() = allocator?.totalBytesAllocated?.toLong() ?: 0L
 

packages/react-native-video/android/src/main/java/com/video/hybrids/videoplayer/HybridVideoPlayer.kt

@@ -183,10 +183,6 @@ class HybridVideoPlayer: HybridVideoPlayerSpec, NativeVideoPlayerSpec {
     return player?.rate != 0
   }
 
-  func clean() throws {
-    release()
-  }
-
   func release() {
     playerQueue.async { [weak self] in
       guard let self = self else { return }
@@ -494,6 +490,10 @@ class HybridVideoPlayer: HybridVideoPlayerSpec, NativeVideoPlayerSpec {
   }
 
   // MARK: - Memory Management
+  
+  func dispose() {
+    release()
+  }
 
   var memorySize: Int {
     var size = 0