Skip to content
This repository was archived by the owner on Oct 24, 2021. It is now read-only.

Conversation

@CarlosFdez
Copy link
Contributor

@CarlosFdez CarlosFdez commented Nov 9, 2020

Tracking additional requested elements

Adds match length, turn duration history, discover history, and the corruption mechanic.

There is one breaking change: cardEntityId was renamed to entityId to match across the board.

@codecov-io
Copy link

Codecov Report

Merging #91 (4fb9eca) into master (55c71d6) will increase coverage by 4.22%.
The diff coverage is 90.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   85.92%   90.15%   +4.22%     
==========================================
  Files          20       27       +7     
  Lines         341      782     +441     
  Branches       52      101      +49     
==========================================
+ Hits          293      705     +412     
- Misses         33       59      +26     
- Partials       15       18       +3     
Impacted Files Coverage Δ
src/data/meta.ts 100.00% <ø> (ø)
src/line-parsers/new-player.ts 100.00% <ø> (+16.66%) ⬆️
src/LogWatcher.ts 54.63% <38.09%> (-7.59%) ⬇️
src/line-parsers/match-log/util.ts 71.42% <71.42%> (ø)
src/line-parsers/game-over.ts 93.75% <80.00%> (+0.89%) ⬆️
src/line-parsers/match-log/index.ts 91.47% <91.47%> (ø)
src/line-parsers/match-log/context.ts 93.33% <93.33%> (ø)
src/line-parsers/discovery.ts 94.82% <94.82%> (ø)
src/line-parsers/readers/base.ts 96.00% <96.00%> (ø)
src/GameState.ts 96.05% <96.92%> (+4.38%) ⬆️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0036bb6...4fb9eca. Read the comment docs.

@CarlosFdez CarlosFdez changed the title WIP Additional tracking Additional tracking Dec 15, 2020
@CarlosFdez CarlosFdez requested a review from Hoishin December 15, 2020 04:18
@CarlosFdez CarlosFdez changed the title Additional tracking feat: additional tracking Dec 17, 2020
@CarlosFdez CarlosFdez merged commit 8d4c7c8 into master Dec 17, 2020
@CarlosFdez CarlosFdez deleted the additional-tracking branch December 17, 2020 09:00
@CarlosFdez
Copy link
Contributor Author

Its been a bit and certain other things depend on this, so I'm going to merge it in. Let me know if I shouldn't do this going forward.

@github-actions
Copy link
Contributor

🎉 This PR is included in version 5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants