You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[android][test] Explicitly sign chars to match expectations
`char` is not always signed by default. In fact, the signedness
of the `char` datatype in C is undefined. That means that on some
architectures, the `c_layout.sil` test fails, because it expects
the IR for `char chareth(char a);` to use `signedext`, whereas
some architectures treat these types as unsigned, and thus
`zeroext` is used.
In order to ensure identical signedness on all platforms the tests
run on, explicitly specify the signedness using the compiler flag
`-fsigned-char`.
It would be better to test the signedness for each platform, as
suggested in swiftlang#1103. This is an
interim solution.
0 commit comments