SUMO-262842 Fix xhr instrumentation span check (#108)

* Fix xhr instrumentation span check

* fixing Uts

Author: ssharma-sumo

e2e_test/demoApps/fixtures/angularjs.hash-second-batch.traces.json

@@ -275,6 +275,30 @@
                     "stringValue": "OK"
                   }
                 },
+                {
+                  "key": "http.time_in_xhr_calls",
+                  "value": {
+                    "intValue": 19000064
+                  }
+                },
+                {
+                  "key": "http.time_to_first_xhr",
+                  "value": {
+                    "intValue": 0
+                  }
+                },
+                {
+                  "key": "http.time_to_last_xhr",
+                  "value": {
+                    "intValue": 19000064
+                  }
+                },
+                {
+                  "key": "http.time_to_xhr_processing_end",
+                  "value": {
+                    "intValue": 19000064
+                  }
+                },
                 {
                   "key": "http.host",
                   "value": {
@@ -580,6 +604,30 @@
                   "value": {
                     "stringValue": "http://localhost:52360/angularjs/index_hash.html#!/angularjs/planet/3"
                   }
+                },
+                {
+                  "key": "http.time_in_xhr_calls",
+                  "value": {
+                    "intValue": 60000000
+                  }
+                },
+                {
+                  "key": "http.time_to_first_xhr",
+                  "value": {
+                    "intValue": 7000064
+                  }
+                },
+                {
+                  "key": "http.time_to_last_xhr",
+                  "value": {
+                    "intValue": 67000064
+                  }
+                },
+                {
+                  "key": "http.time_to_xhr_processing_end",
+                  "value": {
+                    "intValue": 67000064
+                  }
                 }
               ],
               "droppedAttributesCount": 0,

e2e_test/demoApps/fixtures/angularjs.historyapi-second-batch.traces.json

@@ -275,6 +275,30 @@
                     "stringValue": "OK"
                   }
                 },
+                {
+                  "key": "http.time_in_xhr_calls",
+                  "value": {
+                    "intValue": 20000000
+                  }
+                },
+                {
+                  "key": "http.time_to_first_xhr",
+                  "value": {
+                    "intValue": 0
+                  }
+                },
+                {
+                  "key": "http.time_to_last_xhr",
+                  "value": {
+                    "intValue": 20000000
+                  }
+                },
+                {
+                  "key": "http.time_to_xhr_processing_end",
+                  "value": {
+                    "intValue": 20000000
+                  }
+                },
                 {
                   "key": "http.host",
                   "value": {
@@ -580,6 +604,30 @@
                   "value": {
                     "stringValue": "http://localhost:52375/angularjs/planet/3"
                   }
+                },
+                {
+                  "key": "http.time_in_xhr_calls",
+                  "value": {
+                    "intValue": 54999808
+                  }
+                },
+                {
+                  "key": "http.time_to_first_xhr",
+                  "value": {
+                    "intValue": 6000128
+                  }
+                },
+                {
+                  "key": "http.time_to_last_xhr",
+                  "value": {
+                    "intValue": 60999936
+                  }
+                },
+                {
+                  "key": "http.time_to_xhr_processing_end",
+                  "value": {
+                    "intValue": 60999936
+                  }
                 }
               ],
               "droppedAttributesCount": 0,

e2e_test/demoApps/fixtures/react.hash-second-batch.traces.json

@@ -482,6 +482,30 @@
                     "stringValue": "OK"
                   }
                 },
+                {
+                  "key": "http.time_in_xhr_calls",
+                  "value": {
+                    "intValue": 260000000
+                  }
+                },
+                {
+                  "key": "http.time_to_first_xhr",
+                  "value": {
+                    "intValue": 0
+                  }
+                },
+                {
+                  "key": "http.time_to_last_xhr",
+                  "value": {
+                    "intValue": 260000000
+                  }
+                },
+                {
+                  "key": "http.time_to_xhr_processing_end",
+                  "value": {
+                    "intValue": 260000000
+                  }
+                },
                 {
                   "key": "http.host",
                   "value": {

e2e_test/demoApps/fixtures/react.historyapi-second-batch.traces.json

@@ -482,6 +482,30 @@
                     "stringValue": "OK"
                   }
                 },
+                {
+                  "key": "http.time_in_xhr_calls",
+                  "value": {
+                    "intValue": 227000064
+                  }
+                },
+                {
+                  "key": "http.time_to_first_xhr",
+                  "value": {
+                    "intValue": 0
+                  }
+                },
+                {
+                  "key": "http.time_to_last_xhr",
+                  "value": {
+                    "intValue": 227000064
+                  }
+                },
+                {
+                  "key": "http.time_to_xhr_processing_end",
+                  "value": {
+                    "intValue": 227000064
+                  }
+                },
                 {
                   "key": "http.host",
                   "value": {

src/sumologic-span-processor/utils.ts

@@ -5,8 +5,19 @@ import { XHR_IS_ROOT_SPAN } from '../constants';
 export const useWindow = typeof window === 'object' && window != null;
 export const useDocument = typeof document === 'object' && document != null;
 
+const METHOD_NAMES = ['GET', 'POST', 'PUT', 'DELETE', 'OPTIONS'];
+
+const isXhrInstrumentationSpan = (span: SdkTraceSpan) => {
+  return (
+    span.instrumentationLibrary.name ===
+      '@opentelemetry/instrumentation-xml-http-request' &&
+    METHOD_NAMES.includes(span.name)
+  );
+};
+
 export const isXhrSpan = (span: SdkTraceSpan): boolean =>
-  span.name.startsWith('HTTP ') && span.kind === SpanKind.CLIENT;
+  (span.name.startsWith('HTTP ') || isXhrInstrumentationSpan(span)) &&
+  span.kind === SpanKind.CLIENT;
 
 export const isDocumentLoadSpan = (span: SdkTraceSpan): boolean =>
   span.name === 'documentLoad' &&