[BugFix] skip purge unused pages in failure_writer() (backport #58874) (#58894)

mergify[bot] · kevincai · web-flow · commit 2ce6e688118c · 2025-05-12T12:18:53.000Z
Signed-off-by: Kevin Cai &lt;kevin.cai@celerdata.com&gt;
Co-authored-by: Kevin Cai &lt;caixiaohua@starrocks.com&gt;
diff --git a/be/src/common/logconfig.cpp b/be/src/common/logconfig.cpp
@@ -156,9 +156,6 @@ static void failure_handler_after_output_log() {
 }
 
 static void failure_writer(const char* data, size_t size) {
-    if (config::enable_core_file_size_optimization) {
-        dontdump_unused_pages();
-    }
     dump_trace_info();
     [[maybe_unused]] auto wt = write(STDERR_FILENO, data, size);
 }

Original file line number	Diff line number	Diff line change
`@@ -156,9 +156,6 @@ static void failure_handler_after_output_log() {`
`156`	`156`	`}`
`157`	`157`
`158`	`158`	`static void failure_writer(const char* data, size_t size) {`
`159`		`- if (config::enable_core_file_size_optimization) {`
`160`		`- dontdump_unused_pages();`
`161`		`- }`
`162`	`159`	`dump_trace_info();`
`163`	`160`	`[[maybe_unused]] auto wt = write(STDERR_FILENO, data, size);`
`164`	`161`	`}`