added tests

Author: SpectraL519

include/ap/argument_parser.hpp

@@ -497,7 +497,6 @@ class argument_parser {
                 arg_name, "An argument name cannot be empty."
             );
 
-        // TODO: add tests
         if (detail::contains_whitespaces(arg_name))
             throw invalid_configuration::invalid_argument_name(
                 arg_name, "An argument name cannot contain whitespaces."

include/ap/detail/str_utility.hpp

@@ -29,7 +29,6 @@ template <c_writable T>
     return oss.str();
 }
 
-// TODO: add tests
 /// @brief Checks whether a string contains any whitespace characters.
 [[nodiscard]] inline bool contains_whitespaces(std::string_view str) noexcept {
     return std::ranges::any_of(str, [](unsigned char c) { return std::isspace(c); });

tests/source/test_argument_parser_add_argument.cpp

@@ -21,6 +21,7 @@ struct test_argument_parser_add_argument : public argument_parser_test_fixture {
     const std::string_view secondary_name_2 = "s2";
 
     const std::string_view invalid_name_empty = "";
+    const std::string_view invalid_name_whitespace = "invalid name";
     const std::string_view invalid_name_flag_prefix = "-invalid";
     const std::string_view invalid_name_digit = "1invalid";
 };
@@ -37,6 +38,11 @@ TEST_CASE_FIXTURE(
         reason = "An argument name cannot be empty.";
     }
 
+    SUBCASE("The name contains whitespace characters") {
+        primary_name = invalid_name_whitespace;
+        reason = "An argument name cannot contain whitespaces.";
+    }
+
     SUBCASE("The name begins with the flag prefix character") {
         primary_name = invalid_name_flag_prefix;
         reason = "An argument name cannot begin with a flag prefix character (-).";
@@ -75,6 +81,11 @@ TEST_CASE_FIXTURE(
         reason = "An argument name cannot be empty.";
     }
 
+    SUBCASE("The name contains whitespace characters") {
+        primary_name = invalid_name_whitespace;
+        reason = "An argument name cannot contain whitespaces.";
+    }
+
     SUBCASE("The name begins with the flag prefix character") {
         primary_name = invalid_name_flag_prefix;
         reason = "An argument name cannot begin with a flag prefix character (-).";
@@ -113,6 +124,11 @@ TEST_CASE_FIXTURE(
         reason = "An argument name cannot be empty.";
     }
 
+    SUBCASE("The name contains whitespace characters") {
+        secondary_name = invalid_name_whitespace;
+        reason = "An argument name cannot contain whitespaces.";
+    }
+
     SUBCASE("The name begins with the flag prefix character") {
         secondary_name = invalid_name_flag_prefix;
         reason = "An argument name cannot begin with a flag prefix character (-).";
@@ -141,8 +157,7 @@ TEST_CASE_FIXTURE(
 
 TEST_CASE_FIXTURE(
     test_argument_parser_add_argument,
-    "add_positional_argument should throw only when adding an"
-    "argument with a previously used name"
+    "add_positional_argument should throw when adding an argument with a previously used name"
 ) {
     sut.add_positional_argument(primary_name_1, secondary_name_1);
 
@@ -169,8 +184,7 @@ TEST_CASE_FIXTURE(
 
 TEST_CASE_FIXTURE(
     test_argument_parser_add_argument,
-    "add_optional_argument should throw only when adding an"
-    "argument with a previously used name"
+    "add_optional_argument should throw when adding an argument with a previously used name"
 ) {
     sut.add_optional_argument(primary_name_1, secondary_name_1);
 
@@ -226,7 +240,7 @@ TEST_CASE_FIXTURE(
 
 TEST_CASE_FIXTURE(
     test_argument_parser_add_argument,
-    "add_flag should throw only when adding and argument with a previously used name"
+    "add_flag should throw when adding and argument with a previously used name"
 ) {
     sut.add_flag(primary_name_1, secondary_name_1);
 

tests/source/test_str_utility.cpp

@@ -4,6 +4,8 @@
 
 #include <ap/detail/str_utility.hpp>
 
+#include <array>
+#include <format>
 #include <vector>
 
 using namespace ap::detail;
@@ -12,10 +14,39 @@ namespace {
 
 constexpr std::string_view delimiter = ",";
 
+struct dummy_writable {
+    int x;
+    int y;
+};
+
+std::ostream& operator<<(std::ostream& os, const dummy_writable& dw) {
+    os << dw.x << "," << dw.y;
+    return os;
+}
+
 } // namespace
 
 TEST_SUITE_BEGIN("test_str_utility");
 
+TEST_CASE("as_string should convert the given writable object to string") {
+    int value = 5;
+    CHECK_EQ(as_string(value), std::to_string(value));
+
+    dummy_writable dw{3, 14};
+    std::ostringstream dw_oss;
+    dw_oss << dw;
+    CHECK_EQ(as_string(dw), dw_oss.str());
+}
+
+TEST_CASE("contains_whitespace should return true for strings containing at least one whitespace "
+          "characted") {
+    CHECK_FALSE(contains_whitespaces("str-without-whitespaces"));
+
+    constexpr std::array<char, 6> whitespace_chars = {' ', '\t', '\n', '\v', '\f', '\r'};
+    for (char c : whitespace_chars)
+        CHECK(contains_whitespaces(std::format("begin{}end", c)));
+}
+
 TEST_CASE("join should return an empty string for an empty range") {
     std::vector<int> range{};
     CHECK_EQ(join(range, delimiter), "");