fix(🤖): Add flag to build librnskia.so for 16 KB page sizes to android CMakeLists.txt (#3177)

lennyerik · wcandillon · web-flow · commit cc0278fba1f3 · 2025-06-24T12:55:55.000+02:00
---------

Co-authored-by: William Candillon &lt;wcandillon@gmail.com&gt;
diff --git a/packages/skia/android/CMakeLists.txt b/packages/skia/android/CMakeLists.txt
@@ -335,3 +335,8 @@ else()
         -lEGL
     )
 endif()
+
+# Enable Android 16kb native library alignment
+if(CMAKE_ANDROID_NDK_VERSION VERSION_LESS "27")
+    target_link_options(${PACKAGE_NAME} PRIVATE "-Wl,-z,max-page-size=16384")
+endif()
diff --git a/packages/skia/android/build.gradle b/packages/skia/android/build.gradle
@@ -156,7 +156,8 @@ android {
                 arguments '-DANDROID_STL=c++_shared',
                           "-DREACT_NATIVE_VERSION=${REACT_NATIVE_VERSION}",
                           "-DNODE_MODULES_DIR=${nodeModules}",
-                          "-DPREBUILT_DIR=${prebuiltDir}"
+                          "-DPREBUILT_DIR=${prebuiltDir}",
+                          "-DANDROID_SUPPORT_FLEXIBLE_PAGE_SIZES=ON"
 
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -335,3 +335,8 @@ else()`
`335`	`335`	`-lEGL`
`336`	`336`	`)`
`337`	`337`	`endif()`
	`338`	`+`
	`339`	`+# Enable Android 16kb native library alignment`
	`340`	`+if(CMAKE_ANDROID_NDK_VERSION VERSION_LESS "27")`
	`341`	`+ target_link_options(${PACKAGE_NAME} PRIVATE "-Wl,-z,max-page-size=16384")`
	`342`	`+endif()`
Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,8 @@ android {`
`156`	`156`	`arguments '-DANDROID_STL=c++_shared',`
`157`	`157`	`"-DREACT_NATIVE_VERSION=${REACT_NATIVE_VERSION}",`
`158`	`158`	`"-DNODE_MODULES_DIR=${nodeModules}",`
`159`		`- "-DPREBUILT_DIR=${prebuiltDir}"`
	`159`	`+ "-DPREBUILT_DIR=${prebuiltDir}",`
	`160`	`+ "-DANDROID_SUPPORT_FLEXIBLE_PAGE_SIZES=ON"`
`160`	`161`
`161`	`162`	`}`
`162`	`163`	`}`