CORTX-30083:Fix Codacy issues under "net" directory

    This patch fixes some of the codacy warnings in "net" dir.

Signed-off-by: Vinoth.V <[email protected]>

Author: Vinoth2101

net/bulk_emulation/st/main.c

@@ -256,7 +256,7 @@ void client(struct client_params *params)
 	if (params->xprt->px_3part_addr) {
 		cctx.pc_port = params->base_port;
 		cctx.pc_id   = params->client_id;
-		sprintf(ident, "Client %d:%d", cctx.pc_port, cctx.pc_id);
+		sprintf(ident, "Client %d:%u", cctx.pc_port, cctx.pc_id);
 		cctx.pc_rid  = PART3_SERVER_ID;
 	} else {
 		cctx.pc_port = params->base_port + params->client_id;

net/bulk_emulation/st/ping.c

@@ -136,6 +136,9 @@ int encode_msg(struct m0_net_buffer *nb, const char *str)
 	struct m0_bufvec_cursor incur;
 	struct m0_bufvec_cursor cur;
 
+	if(nb == NULL)
+		return -1;
+
 	nb->nb_length = len + 1;
 	m0_bufvec_cursor_init(&cur, &nb->nb_buffer);
 	bp = m0_bufvec_cursor_addr(&cur);
@@ -1189,6 +1192,7 @@ int ping_client_passive_send(struct ping_ctx *ctx,
 	M0_ASSERT(nb != NULL);
 	/* reuse encode_msg for convenience */
 	rc = encode_msg(nb, data);
+	M0_ASSERT(rc == 0);
 	nb->nb_qtype = M0_NET_QT_PASSIVE_BULK_SEND;
 	nb->nb_ep = server_ep;
 	if (ctx->pc_passive_bulk_timeout > 0) {

net/ip.c

@@ -275,7 +275,7 @@ static int m0_net_ip_lnet_parse(const char *name, struct m0_net_ip_addr *addr)
 	portnum  = tmid | (1 << 10) | ((portal - 30) << 11);
 	if (portnum > M0_NET_IP_PORT_MAX)
 		return M0_ERR(-EINVAL);
-	snprintf(port, ARRAY_SIZE(port), "%d", (uint32_t)portnum);
+	snprintf(port, ARRAY_SIZE(port), "%u", (uint32_t)portnum);
 	addr->nia_n.nip_format = M0_NET_IP_LNET_FORMAT;
 	inet_pton(AF_INET, node, &addr->nia_n.nip_ip_n.sn[0]);
 	addr->nia_n.nip_fmt_pvt.la.nla_tmid = (uint16_t)tmid;

net/net.c

@@ -28,9 +28,7 @@
 #include "lib/memory.h"
 #include "lib/misc.h"
 #include "lib/mutex.h"
-#ifndef __KERNEL__
-#  include "lib/string.h"  /* m0_streq */
-#endif
+#include "lib/string.h"
 
 #define M0_TRACE_SUBSYSTEM M0_TRACE_SUBSYS_NET
 #include "lib/trace.h"

net/sock/sock.c

@@ -2386,6 +2386,7 @@ static int ep_find(struct ma *ma, const char *name, struct ep **out)
 /** Returns end-point transfer machine. */
 static struct ma *ep_ma(struct ep *ep)
 {
+	M0_PRE(ep != NULL);
 	return ep->e_ep.nep_tm->ntm_xprt_private;
 }
 

net/test/demo/test.sh

@@ -187,6 +187,7 @@ static int net_test_buf_init(struct m0_net_buffer *buf,
 static void net_test_buf_fini(struct m0_net_buffer *buf,
 			      struct m0_net_domain *dom)
 {
+	M0_PRE(buf != NULL);
 	M0_PRE(buf->nb_dom == dom);
 
 	m0_net_buffer_deregister(buf, dom);

net/test/network.c

@@ -850,10 +850,10 @@ static void node_bulk_cb(struct m0_net_test_network_ctx *net_ctx,
 	bool			 buf_send;
 	bool			 buf_bulk;
 
+	M0_PRE(net_ctx != NULL);
 	LOGD("node_bulk_cb: tm_addr = %s, buf_index = %u, q = %d"
 	     ", ev-nbe_status = %d",
 	     net_ctx->ntc_tm->ntm_ep->nep_addr, buf_index, q, ev->nbe_status);
-	M0_PRE(net_ctx != NULL);
 	role_client = ctx->nbc_nh.ntnh_role == M0_NET_TEST_ROLE_CLIENT;
 	M0_PRE(ergo(q == M0_NET_QT_MSG_RECV, !role_client));
 	M0_PRE(ergo(q == M0_NET_QT_MSG_SEND, role_client));

net/test/node_bulk.c

@@ -22,10 +22,10 @@
 CWD=$(cd "$( dirname "$0")" && pwd)
 
 source "$CWD"/st-config.sh
-TEST_TYPE="ping"
-MSG_NR=1048576
-MSG_SIZE=4k
-CONCURRENCY_CLIENT=8
-CONCURRENCY_SERVER=16
+export TEST_TYPE="ping"
+export MSG_NR=1048576
+export MSG_SIZE=4k
+export CONCURRENCY_CLIENT=8
+export CONCURRENCY_SERVER=16
 
 source "$CWD"/run-1x1.sh

net/test/st/st-ping.sh

@@ -671,6 +671,7 @@ static void commands_node_thread2(struct net_test_cmd_node *node)
 
 	M0_ALLOC_PTR(cmd);
 	M0_UT_ASSERT(cmd != NULL);
+	M0_UT_ASSERT(nodes != NULL);
 
 	if (console_thread) {
 		buf[0] = '\0';