Skip to content
This repository was archived by the owner on May 3, 2024. It is now read-only.

Commit 2a684e5

Browse files
alfhadrkothiya
authored andcommitted
CORTX-30751: Codacy code cleanup (#1606)
This patch fixes some of the codacy warnings. warning fixed : "Double quote to prevent globing and words splitting". Signed-off-by: alfhad <[email protected]>
1 parent 8408bd1 commit 2a684e5

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

spiel/st/m0t1fs_spiel_sns_repair.sh

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ spiel_sns_repair_and_rebalance_test()
3131
local fail_device2=9
3232
local fail_device3=3
3333

34-
local_write $src_bs $src_count || return $?
34+
local_write "$src_bs" "$src_count" || return $?
3535

3636
echo "Starting SNS repair testing ..."
3737
for ((i=0; i < ${#files[*]}; i++)) ; do
@@ -146,7 +146,7 @@ test_repaired_device_failure()
146146
echo "SNS Rebalance done."
147147

148148
verify || return $?
149-
disk_state_get $fail_device1 || return $?
149+
disk_state_get "$fail_device1" || return $?
150150
}
151151

152152
test_new_device_failure()
@@ -182,7 +182,7 @@ test_new_device_failure()
182182
echo "SNS Rebalance done."
183183

184184
verify || return $?
185-
disk_state_get $fail_device1 $fail_device2 || return $?
185+
disk_state_get "$fail_device1" "$fail_device2" || return $?
186186
}
187187

188188
rebalance_abort()
@@ -206,8 +206,8 @@ rebalance_abort()
206206
echo "SNS Repair done."
207207
verify || return $?
208208

209-
disk_state_set "rebalance" $fail_device1 || return $?
210-
disk_state_get $fail_device1 || return $?
209+
disk_state_set "rebalance" "$fail_device1" || return $?
210+
disk_state_get "$fail_device1" || return $?
211211
sleep 2
212212
echo "Starting SNS Re-balance.."
213213
spiel_sns_rebalance_start
@@ -218,7 +218,7 @@ rebalance_abort()
218218
spiel_wait_for_sns_rebalance || return $?
219219

220220
echo "Set $fail_device1 back to "repaired""
221-
disk_state_set "repaired" $fail_device1 || return $?
221+
disk_state_set "repaired" "$fail_device1" || return $?
222222
if [ "$fail_device1" -eq "$fail_device2" ]
223223
then
224224
test_repaired_device_failure "$fail_device1"

0 commit comments

Comments
 (0)