CORTX-32290: Added normalize path middleware (#900)

* CORTX-32290: Added normalize path middleware

Signed-off-by: Rohit Kolapkar <[email protected]>

* Sending resposne as a CSMResponse wherever it is missing

Signed-off-by: Rohit Kolapkar <[email protected]>

* Reverting unwanted changes

Signed-off-by: Rohit Kolapkar <[email protected]>

Signed-off-by: Rohit Kolapkar <[email protected]>
Co-authored-by: kupranay <[email protected]>

Author: Rohit Kolapkar

csm/core/agent/api.py

@@ -26,7 +26,9 @@
 from asyncio import CancelledError as AsyncioCancelledError
 from weakref import WeakSet
 from aiohttp import web, web_exceptions
-from aiohttp.client_exceptions import ServerDisconnectedError, ClientConnectorError, ClientOSError
+from aiohttp.client_exceptions import (ServerDisconnectedError,
+    ClientConnectorError, ClientOSError)
+from aiohttp.web_middlewares import normalize_path_middleware
 from abc import ABC
 from secure import SecureHeaders
 from typing import Dict, Tuple
@@ -116,11 +118,14 @@ def init():
         Log.info(f"CSM request quota is set to {CsmRestApi.__request_quota}")
 
         CsmRestApi._app = web.Application(
-            middlewares=[CsmRestApi.throttler_middleware,
+            middlewares=[normalize_path_middleware(remove_slash=True,
+                            append_slash = False),
+                         CsmRestApi.throttler_middleware,
                          CsmRestApi.set_secure_headers,
                          CsmRestApi.rest_middleware,
                          CsmRestApi.session_middleware,
-                         CsmRestApi.permission_middleware]
+                         CsmRestApi.permission_middleware
+                        ]
         )
 
         CsmRoutes.add_routes(CsmRestApi._app)

csm/core/controllers/login.py

@@ -67,4 +67,3 @@ async def post(self):
         # TODO: Stop any websocket connection corresponding to this session
         Log.info(f"[{self.request.request_id}] Logout successful. User: {username}")
         return CsmResponse()
-        

csm/core/controllers/users.py

@@ -199,4 +199,3 @@ async def patch(self):
             f"[{self.request.request_id}] Processed request: {self.request.method} {self.request.path}"\
             f" User: {loggedin_user_id}")
         return resp
-