Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

Commit addefdb

Browse files
committed
CORTX-33789: Hare Config stage fail with Motr Clients
Problem: If num_client_inst is specified a non-zero value, deployment is failing. Issue is with search key. For data nodes we used 'io':'motr', it returns the list of machine IDs which includes both data node and motr client nodes, because of which deployment was failing. Solution: Separated search key for data node and motr client node. Signed-off-by: pavankrishnat <[email protected]>
1 parent 150112e commit addefdb

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

provisioning/miniprov/hare_mp/store.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,13 @@ def get_machine_ids_for_service(self, service_type: str) -> List[str]:
9292
service_type will be like Const.SERVICE_MOTR_IO.value,
9393
Const.SERVICE_S3_SERVER.value etc
9494
"""
95+
if service_type == 'io':
96+
return self.get_machine_ids_for_attribute('num_cvg')
97+
# presently, For service_type: motr_client, both client and data pods
98+
# are returned by the conf store search query. But data pods are
99+
# filtered out while creating node in _create_node().
95100
types = {
96-
'io': 'motr',
101+
'motr_client': 'motr',
97102
'rgw_s3': 'rgw',
98103
'agent': 'csm'
99104
}
@@ -121,7 +126,7 @@ def get_machine_ids_for_component(self, comp_type: str) -> List[str]:
121126
return self.get_machine_ids_for_attribute('name', comp_type)
122127

123128
def get_machine_ids_for_attribute(self, attr_type: str,
124-
name: str) -> List[str]:
129+
name: str = None) -> List[str]:
125130
"""
126131
Return a list of pod's machine_id for the machines consisting
127132
the attribute name under the given attribute type.
@@ -173,7 +178,7 @@ def get_data_nodes(self) -> List[str]:
173178
return self.get_machine_ids_for_service(Const.SERVICE_MOTR_IO.value)
174179

175180
def search_val(self, parent_key: str, search_key: str,
176-
search_val: str) -> List[str]:
181+
search_val: str = None) -> List[str]:
177182
"""
178183
Searches a given key value under the given parent key.
179184
"""

0 commit comments

Comments
 (0)