CORTX-33876: Log device size should be power of 2 with limits

The validation for log device size was missing which resulted
in failure of cluster bootstrap. Default size
was taken from lsblk if not provided via confstore.

Solution:
Following motr constraints are considered:
- the log device size upper and lower bounds is set to 4GB and
128MB respectively.
- The size of the log device is rounded off to the nearest
power of 2.

Signed-off-by: Shreya Karmakar <[email protected]>

Author: Shreya-18

cfgen/cfgen

@@ -19,7 +19,7 @@ import socket
 import subprocess
 from typing import (Any, Callable, Dict, Iterable, Iterator, List, NamedTuple,
                     Optional, Set, Type, Tuple)
-from math import floor, ceil
+from math import floor, ceil, log as lg
 from hax.log import create_logger_directory
 from hax.types import ObjTMaskMap, QW_F, Fid
 from hax.types import ObjT as HaxObjT
@@ -455,6 +455,7 @@ def enrich_cluster_desc(desc: Dict[str, Any], mock_p: bool) -> None:
             if not m0d['_log_disks']:
                 m0d['_log_disks'] = get_disks_ssh(node['hostname'], mock_p,
                                                   m0d['io_disks']['log'])
+            set_log_disks_size(m0d['_log_disks'], host)
 
     if 'profiles' not in desc:
         sns_pools = [pool['name'] for pool in desc['pools']
@@ -819,6 +820,34 @@ def fabricate_disks(hostname: str, paths: List[str]) -> List[Disk]:
     return [Disk(path=x, size=0, blksize=4096) for x in paths]
 
 
+def set_log_disks_size(log_disks: List[Disk], host: str) -> None:
+    """
+    Update the log disk size provided by the user/lsblk based on the
+    motr constraints.
+    """
+    def powOf2(num: int) -> int:
+        power = int(lg(num, 2))
+        return int(pow(2, power))
+
+    KB = int(1024)
+    MB = int(KB ** 2)
+    GB = int(KB ** 3)
+    # [TODO] Hardcoded constraints based on motr requirements.
+    upper_bound = 4*GB
+    lower_bound = 128*MB
+
+    # Rounding of log device size to the nearest(lower) power of 2.
+    for i, disk in enumerate(log_disks):
+        print(dir(disk))
+        print(disk.size)
+        size = powOf2(disk.size)
+        _assert(size >= lower_bound, f"Node {host}: Log device size "
+                f"in 'io_disks.log' is below {lower_bound}")
+        if size > upper_bound:
+            size = upper_bound
+        log_disks[i] = disk._replace(size=size)
+
+
 ObjT = Enum('ObjT', 'root fdmi_flt_grp fdmi_filter'
             ' node process service sdev'  # software subtree
             ' site rack enclosure controller drive'  # hardware subtree