Skip to content

Commit cbc497c

Browse files
authored
feat: add chart.js v4 support (#86)
1 parent 1d221e3 commit cbc497c

File tree

3 files changed

+1832
-828
lines changed

3 files changed

+1832
-828
lines changed

.storybook/main.js

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,22 @@
11
const path = require('path');
2-
const ResolveTypeScriptPlugin = require('resolve-typescript-plugin');
2+
const { mergeConfig } = require('vite');
3+
const preprocess = require('svelte-preprocess');
34

45
module.exports = {
5-
webpackFinal: async config => {
6-
const svelteLoader = config.module.rules.find(
7-
r => r.loader && r.loader.includes('svelte-loader')
8-
);
9-
svelteLoader.options.preprocess = require('svelte-preprocess')({});
10-
config.resolve.alias['svelte-chartjs'] = path.resolve(__dirname, '../src');
11-
config.resolve.plugins.push(new ResolveTypeScriptPlugin());
12-
return config;
6+
core: {
7+
builder: '@storybook/builder-vite',
8+
},
9+
viteFinal(config) {
10+
return mergeConfig(config, {
11+
resolve: {
12+
alias: {
13+
'svelte-chartjs': path.resolve(__dirname, '../src'),
14+
},
15+
},
16+
});
17+
},
18+
svelteOptions: {
19+
preprocess: preprocess(),
1320
},
1421
stories: ['../stories/*.stories.(js|ts)'],
1522
addons: ['@storybook/addon-essentials'],

package.json

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
"updateGitHooks": "simple-git-hooks"
4444
},
4545
"peerDependencies": {
46-
"chart.js": "^3.5.0",
46+
"chart.js": "^3.5.0 || ^4.0.0",
4747
"svelte": "^3.45.0"
4848
},
4949
"devDependencies": {
@@ -52,15 +52,22 @@
5252
"@commitlint/cz-commitlint": "^17.0.0",
5353
"@size-limit/preset-big-lib": "^8.0.0",
5454
"@storybook/addon-actions": "^6.5.9",
55+
"@storybook/addon-backgrounds": "^6.5.13",
56+
"@storybook/addon-docs": "^6.5.13",
5557
"@storybook/addon-essentials": "^6.5.9",
58+
"@storybook/addon-measure": "^6.5.13",
59+
"@storybook/addon-outline": "^6.5.13",
60+
"@storybook/builder-vite": "^0.2.5",
61+
"@storybook/client-api": "^6.5.13",
62+
"@storybook/client-logger": "^6.5.13",
5663
"@storybook/svelte": "^6.5.9",
5764
"@sveltejs/package": "^1.0.0-next.3",
5865
"@sveltejs/vite-plugin-svelte": "^1.0.5",
5966
"@testing-library/svelte": "^3.2.1",
6067
"@typescript-eslint/eslint-plugin": "^5.30.6",
6168
"@typescript-eslint/parser": "^5.30.6",
6269
"@vitest/coverage-c8": "^0.25.0",
63-
"chart.js": "^3.8.0",
70+
"chart.js": "^4.0.0",
6471
"clean-publish": "^4.0.1",
6572
"commitizen": "^4.2.4",
6673
"cz-conventional-changelog": "^3.3.0",
@@ -72,7 +79,8 @@
7279
"nano-staged": "^0.8.0",
7380
"prettier": "^2.7.1",
7481
"prettier-plugin-svelte": "^2.7.0",
75-
"resolve-typescript-plugin": "^1.2.0",
82+
"react": "^18.2.0",
83+
"react-dom": "^18.2.0",
7684
"simple-git-hooks": "^2.8.0",
7785
"simple-github-release": "^1.0.0",
7886
"size-limit": "^8.0.0",

0 commit comments

Comments
 (0)