Skip to content

[RFR] Add @​name annotation #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pascalduez merged 2 commits into from
Feb 8, 2015
Merged

[RFR] Add @​name annotation #358

pascalduez merged 2 commits into from
Feb 8, 2015

Conversation

@FWeinb
Copy link
Member

@FWeinb FWeinb commented Feb 4, 2015

See #296

@FWeinb FWeinb added the Feature label Feb 4, 2015
@FWeinb FWeinb added this to the 2.1 milestone Feb 4, 2015
@coveralls
Copy link

coveralls commented Feb 4, 2015

Coverage Status

Coverage increased (+0.05%) to 94.07% when pulling 0dda650 on name-annotation-v2 into 30bb313 on develop.

KittyGiraudel
KittyGiraudel reviewed Feb 5, 2015
View reviewed changes
src/annotation/annotations/name.js Outdated
Copy link
Member

@KittyGiraudel KittyGiraudel Feb 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space before brace.

@KittyGiraudel
Copy link
Member

KittyGiraudel commented Feb 5, 2015

It looks fine to me. We should not forget to PR the docs.

@KittyGiraudel KittyGiraudel mentioned this pull request Feb 5, 2015
Merged
@KittyGiraudel
Copy link
Member

KittyGiraudel commented Feb 5, 2015

Boom, docs: SassDoc/sassdoc.github.io#109.

@KittyGiraudel KittyGiraudel changed the title Add @​name annotation [RFR] Add @​name annotation Feb 7, 2015
@KittyGiraudel
Copy link
Member

KittyGiraudel commented Feb 7, 2015

LGTM. 👍

@KittyGiraudel
Copy link
Member

KittyGiraudel commented Feb 7, 2015

@FWeinb Whenever you feel like it.

@coveralls
Copy link

coveralls commented Feb 8, 2015

Coverage Status

Coverage increased (+0.28%) to 94.31% when pulling c25879b on name-annotation-v2 into 30bb313 on develop.

pascalduez added a commit that referenced this pull request Feb 8, 2015
@pascalduez
Merge pull request #358 from SassDoc/name-annotation-v2
341adad 
Add @​name annotation
@pascalduez pascalduez merged commit 341adad into develop Feb 8, 2015
@pascalduez pascalduez deleted the name-annotation-v2 branch February 8, 2015 13:29
@pascalduez pascalduez mentioned this pull request Feb 8, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Feature

Milestone

2.1

Development

Successfully merging this pull request may close these issues.

5 participants

@FWeinb @coveralls @KittyGiraudel @pascalduez