Skip to content

[RFR] Autofill access based on privatePrefix #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
FWeinb wants to merge 5 commits into from
Closed

[RFR] Autofill access based on privatePrefix #357

FWeinb wants to merge 5 commits into from

Conversation

@FWeinb
Copy link
Member

@FWeinb FWeinb commented Feb 4, 2015

See #340

@FWeinb FWeinb mentioned this pull request Feb 4, 2015
Closed
@FWeinb FWeinb added the Feature label Feb 4, 2015
@FWeinb FWeinb added this to the 2.1 milestone Feb 4, 2015
@coveralls
Copy link

coveralls commented Feb 4, 2015

Coverage Status

Coverage increased (+0.05%) to 94.08% when pulling 233bd12 on autofill-access into e12c691 on develop.

KittyGiraudel
KittyGiraudel reviewed Feb 5, 2015
View reviewed changes
src/annotation/annotations/access.js Outdated
Copy link
Member

@KittyGiraudel KittyGiraudel Feb 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing linebreaks here.

@KittyGiraudel
Copy link
Member

KittyGiraudel commented Feb 5, 2015

Looks alright to me. We should not forget to PR the docs.

@KittyGiraudel KittyGiraudel mentioned this pull request Feb 5, 2015
Merged
@KittyGiraudel
Copy link
Member

KittyGiraudel commented Feb 5, 2015

Docs here: SassDoc/sassdoc.github.io#110.

@KittyGiraudel KittyGiraudel changed the title Autofill access based on privatePrefix [RFR] Autofill access based on privatePrefix Feb 7, 2015
@KittyGiraudel
Copy link
Member

KittyGiraudel commented Feb 7, 2015

LGTM. 👍

@KittyGiraudel
Copy link
Member

KittyGiraudel commented Feb 7, 2015

@FWeinb Whenever you feel like it.

@pascalduez
Copy link
Member

pascalduez commented Feb 8, 2015

Manually merged.

@pascalduez pascalduez closed this Feb 8, 2015
@pascalduez pascalduez deleted the autofill-access branch February 8, 2015 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Feature

Milestone

2.1

Development

Successfully merging this pull request may close these issues.

5 participants

@FWeinb @coveralls @KittyGiraudel @pascalduez