v1.8.15

Author: stfnmllr

RELEASENOTES.md

@@ -5,6 +5,9 @@ Release Notes
 
 ### Minor revisions
 
+#### v1.8.15
+- fixed sql value conversion for integers and floats
+
 #### v1.8.14
 - fixed race condition in writing metrics
 

driver/datatype_test.go

@@ -350,42 +350,82 @@ const (
 	maxDouble   = math.MaxFloat64
 )
 
+type (
+	testUint8 uint8
+	testInt8  int8
+)
+
 var tinyintTestData = []any{
+	testUint8(minTinyint),
+	testUint8(maxTinyint),
+	testInt8(minTinyint),
 	uint8(minTinyint),
 	uint8(maxTinyint),
 	sql.NullInt64{Valid: false, Int64: minTinyint},
 	sql.NullInt64{Valid: true, Int64: maxTinyint},
 }
 
+type (
+	testUint16 uint16
+	testInt16  int16
+)
+
 var smallintTestData = []any{
+	testUint16(maxSmallint),
+	testInt16(minSmallint),
+	testInt16(maxSmallint),
 	int16(minSmallint),
 	int16(maxSmallint),
 	sql.NullInt64{Valid: false, Int64: minSmallint},
 	sql.NullInt64{Valid: true, Int64: maxSmallint},
 }
 
+type (
+	testUint32 uint32
+	testInt32  int32
+)
+
 var integerTestData = []any{
+	testUint32(maxInteger),
+	testInt32(minInteger),
+	testInt32(maxInteger),
 	int32(minInteger),
 	int32(maxInteger),
 	sql.NullInt64{Valid: false, Int64: minInteger},
 	sql.NullInt64{Valid: true, Int64: maxInteger},
 }
 
+type (
+	testUint64 uint64
+	testInt64  int64
+)
+
 var bigintTestData = []any{
+	testUint64(maxBigint),
+	testInt64(minBigint),
+	testInt64(maxBigint),
 	int64(minBigint),
 	int64(maxBigint),
 	sql.NullInt64{Valid: false, Int64: minBigint},
 	sql.NullInt64{Valid: true, Int64: maxBigint},
 }
 
+type testFloat32 float32
+
 var realTestData = []any{
+	testFloat32(-maxReal),
+	testFloat32(maxReal),
 	float32(-maxReal),
 	float32(maxReal),
 	sql.NullFloat64{Valid: false, Float64: -maxReal},
 	sql.NullFloat64{Valid: true, Float64: maxReal},
 }
 
+type testFloat64 float64
+
 var doubleTestData = []any{
+	testFloat64(-maxDouble),
+	testFloat64(maxDouble),
 	float64(-maxDouble),
 	float64(maxDouble),
 	sql.NullFloat64{Valid: false, Float64: -maxDouble},

driver/driver.go

@@ -10,7 +10,7 @@ import (
 )
 
 // DriverVersion is the version number of the hdb driver.
-const DriverVersion = "1.8.14"
+const DriverVersion = "1.8.15"
 
 // DriverName is the driver name to use with sql.Open for hdb databases.
 const DriverName = "hdb"

driver/internal/protocol/convert.go

@@ -124,7 +124,7 @@ func convertInteger(tc typeCode, v any, min, max int64) (any, error) {
 		if i64 > max || i64 < min {
 			return nil, newConvertError(tc, v, ErrIntegerOutOfRange)
 		}
-		return v, nil
+		return i64, nil
 	case reflect.Uint, reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64:
 		u64 := rv.Uint()
 		if u64 >= 1<<63 {
@@ -133,7 +133,7 @@ func convertInteger(tc typeCode, v any, min, max int64) (any, error) {
 		if int64(u64) > max || int64(u64) < min {
 			return nil, newConvertError(tc, v, ErrIntegerOutOfRange)
 		}
-		return v, nil
+		return u64, nil
 	// conversions with allocations (return i64)
 	case reflect.Float32, reflect.Float64:
 		f64 := rv.Float()
@@ -178,10 +178,11 @@ func convertFloat(tc typeCode, v any, max float64) (any, error) {
 	switch rv.Kind() {
 	// conversions without allocations (return v)
 	case reflect.Float32, reflect.Float64:
-		if math.Abs(rv.Float()) > max {
+		f64 := rv.Float()
+		if math.Abs(f64) > max {
 			return nil, newConvertError(tc, v, ErrFloatOutOfRange)
 		}
-		return v, nil
+		return f64, nil
 	// conversions with allocations (return f64)
 	case reflect.String:
 		f64, err := strconv.ParseFloat(rv.String(), 64)