fix: update suggestion for 'no-missing-button-type' rule to use dynamic prop name (#1139)

Rel1cx · web-flow · commit 6cd54f9f3bed · 2025-06-22T01:49:02.000+08:00
diff --git a/packages/plugins/eslint-plugin-react-dom/src/rules/no-missing-button-type.ts b/packages/plugins/eslint-plugin-react-dom/src/rules/no-missing-button-type.ts
@@ -71,7 +71,7 @@ export function create(context: RuleContext<MessageID, []>): RuleListener {
           messageId: "noMissingButtonType",
           node,
           suggest: getSuggest((type) => (fixer: RuleFixer) => {
-            return fixer.insertTextAfter(node.openingElement.name, ` type="${type}"`);
+            return fixer.insertTextAfter(node.openingElement.name, ` ${propNameOnJsx}="${type}"`);
           }),
         });
       }

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ export function create(context: RuleContext<MessageID, []>): RuleListener {`
`71`	`71`	`messageId: "noMissingButtonType",`
`72`	`72`	`node,`
`73`	`73`	`suggest: getSuggest((type) => (fixer: RuleFixer) => {`
`74`		- return fixer.insertTextAfter(node.openingElement.name, ` type="${type}"`);
	`74`	+ return fixer.insertTextAfter(node.openingElement.name, ` ${propNameOnJsx}="${type}"`);
`75`	`75`	`}),`
`76`	`76`	`});`
`77`	`77`	`}`