Rescuing from doule JSON serialization must be explicitly enabled

Thus exposing the switch in client facade.

Author: mostlyobvious

ruby_event_store-active_record/lib/ruby_event_store/active_record/event_repository.rb

@@ -32,8 +32,6 @@ def initialize(model_factory: WithDefaultModels.new, serializer:)
           @event_klass.include(SkipJsonSerialization)
         end
         @repo_reader = EventRepositoryReader.new(@event_klass, @stream_klass, serializer)
-        rescue_from_double_json_serialization!
-
         @index_violation_detector = IndexViolationDetector.new(@event_klass.table_name, @stream_klass.table_name)
       end
 

ruby_event_store-active_record/spec/event_repository_spec.rb

@@ -315,6 +315,7 @@ module ActiveRecord
         skip unless %w[json jsonb].include?(ENV["DATA_TYPE"])
 
         repository = EventRepository.new(serializer: JSON)
+        repository.rescue_from_double_json_serialization!
         repository.append_to_stream(
           [SRecord.new(data: JSON.dump({ "simulate" => "double" }))],
           Stream.new("stream"),
@@ -338,6 +339,7 @@ module ActiveRecord
         skip unless %w[json jsonb].include?(ENV["DATA_TYPE"])
 
         repository = EventRepository.new(serializer: JSON)
+        repository.rescue_from_double_json_serialization!
         repository.append_to_stream([SRecord.new(data: "kaka dudu")], Stream.new("stream"), ExpectedVersion.any)
 
         expect(repository.read(specification.backward.limit(1).result).first.data).to eq("kaka dudu")

ruby_event_store/lib/ruby_event_store/client.rb

@@ -45,6 +45,11 @@ def initialize(
       end
     end
 
+    def rescue_from_double_json_serialization!
+      return unless @repository.respond_to? :rescue_from_double_json_serialization!
+      @repository.rescue_from_double_json_serialization!
+    end
+
     # Persists events and notifies subscribed handlers about them
     #
     # @param events [Array<Event>, Event] event(s)

ruby_event_store/spec/client_spec.rb

@@ -1007,5 +1007,17 @@ def event_id
       expect(client.event_in_stream?(fact.event_id, GLOBAL_STREAM)).to be(true)
       expect(client.event_in_stream?("924acfb8-755d-4fd5-b758-f92423b6560a", GLOBAL_STREAM)).to be(false)
     end
+
+    specify "delegate double serialization rescue to supporting repository" do
+      client = Client.new(repository: repository = spy(:event_repository))
+      client.rescue_from_double_json_serialization!
+
+      expect(repository).to have_received(:rescue_from_double_json_serialization!)
+    end
+
+    specify "don't delegate double serialization rescue to not-supporting repository" do
+      client = Client.new(repository: repository = InMemoryRepository.new)
+      expect { client.rescue_from_double_json_serialization! }.not_to raise_error
+    end
   end
 end